Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDP Noise Bug #4237

Closed
4 tasks done
titancomputer opened this issue Jan 1, 2025 · 2 comments · Fixed by #4238
Closed
4 tasks done

UDP Noise Bug #4237

titancomputer opened this issue Jan 1, 2025 · 2 comments · Fixed by #4238

Comments

@titancomputer
Copy link

titancomputer commented Jan 1, 2025

Integrity requirements

  • I confirm that I have read the documentation, understand the meaning of all the configuration items I wrote, and did not pile up seemingly useful options or default values.
  • I provided the complete config and logs, rather than just providing the truncated parts based on my own judgment.
  • I searched issues and did not find any similar issues.
  • The problem can be successfully reproduced in the latest Release

Description

Hi
i think the method of noise creating has problem.

when i use base64 noise, it converts my base64 to string when it's going to send noise.

it should send real base64 or convert them to hex not string.

or may you can add hex noise in addition to str base64 and rand.

please take a look at these debug logs

2025/01/01 23:12:26 [Debug] [3607294496] proxy/freedom: NOISE[delay_min:10 delay_max:16 str_noise:"\xee\x00\x00\x00\x01\x08\xaa\xaa" delay_min:10 delay_max:16

Reproduction Method

run this json with core 25.1.1 and see debug logs
warp_mmm_noise.json

Client config

N/A

Server config

N/A

Client log

2025/01/01 23:12:26 [Debug] peer(bmXO…fgyo) - Sending keepalive packet
2025/01/01 23:12:26 [Info] [3607294496] proxy/freedom: connection opened to udp:188.114.98.55:988, local endpoint [::]:63497, remote endpoint 188.114.98.55:988
2025/01/01 23:12:26 [Debug] [3607294496] proxy/freedom: NOISE[delay_min:10  delay_max:16  str_noise:"\xee\x00\x00\x00\x01\x08\xaa\xaa" delay_min:10  delay_max:16  str_noise:"\xee\x00\x00\x00\x01\x08\xaa\xaa" delay_min:10  delay_max:16  str_noise:"\xee\x00\x00\x00\x01\x08\xaa\xaa" delay_min:10  delay_max:16  str_noise:"\xee\x00\x00\x00\x01\x08\xaa\xaa" delay_min:10  delay_max:16  str_noise:"\xee\x00\x00\x00\x01\x08\xaa\xaa"]
2025/01/01 23:12:26 [Info] [332116113] proxy/socks: TCP Connect request to tcp:www.gstatic.com:80
2025/01/01 23:12:26 [Info] [332116113] app/dispatcher: sniffed domain: www.gstatic.com
2025/01/01 23:12:26 [Info] [332116113] app/dispatcher: taking detour [warpMain] for [tcp:www.gstatic.com:80]
2025/01/01 23:12:26 [Debug] app/dns: domain www.gstatic.com will use DNS in order: [UDP:1.1.1.1:53]
2025/01/01 23:12:26 [Debug] app/dns: UDP:1.1.1.1:53 querying DNS for: www.gstatic.com.
2025/01/01 23:12:27 [Info] [1292005955] proxy/socks: TCP Connect request to tcp:www.gstatic.com:80
2025/01/01 23:12:27 [Info] [1292005955] app/dispatcher: sniffed domain: www.gstatic.com

Server log

N/A

@Fangliding
Copy link
Member

This is a naming legacy. Earlier, we only supported str and used this name internally. Later, we supported base64 without changing this variable name. In fact, your data was indeed sent correctly, but it was displayed in this

@GFW-knocker
Copy link
Contributor

i know what @titancomputer mean.
the problem is we send packet in hex format, not in str
and some hex cant be converted to printable chars to be placed in config.
and converting str back to hex , make different seq of bytes which is not intended.

i made a pr to add hex format
#4239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants