Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copying debug stream to clipboard doesn't preserve newlines #86

Closed
vbar opened this issue Feb 7, 2022 · 6 comments · Fixed by #108 or #150
Closed

Copying debug stream to clipboard doesn't preserve newlines #86

vbar opened this issue Feb 7, 2022 · 6 comments · Fixed by #108 or #150
Assignees
@valstu
Labels
flow: test Hook testing phase specific features & epics type: enhancement And enhancement or proposal to an existing feature

Comments

@vbar
Copy link
Collaborator

vbar commented Feb 7, 2022

while copying the contents of Monaco editor pane works normally, so I don't think the problem is my clipboard; apparently there's some difference between the editor and debug stream panes...
@jonijuup
Copy link
Collaborator

jonijuup commented Mar 2, 2022

Should be fixed with the debug stream improvements: #107

@jonijuup jonijuup added flow: test Hook testing phase specific features & epics type: enhancement And enhancement or proposal to an existing feature labels Mar 2, 2022
@muzam1l muzam1l mentioned this issue Mar 3, 2022
Merged
@vbar
Copy link
Collaborator Author

vbar commented Mar 25, 2022

regressed in #136 (see attached log)
test.log

@vbar vbar reopened this Mar 25, 2022
@vbar vbar assigned valstu and unassigned muzam1l Mar 25, 2022
@valstu
Copy link
Collaborator

valstu commented Mar 25, 2022

This is weird, works for me on mac (tested on safari and chrome/brave)

@vbar
Copy link
Collaborator Author

vbar commented Mar 25, 2022

Hmm, maybe it's Firefox-specific? See also #127 - Hooks builder has some surprising cross-browser differences...

@valstu
Copy link
Collaborator

valstu commented Mar 25, 2022

Just tried out with Firefox and yeah, was able to reproduce this there

@vbar
Copy link
Collaborator Author

vbar commented Mar 25, 2022

I can confirm it also used to be fixed for Firefox... :-)

valstu added a commit that referenced this issue Mar 29, 2022
@valstu
Fixes issue #86 again, regressed in #107 for Firefox
95022ef
@valstu valstu mentioned this issue Mar 29, 2022
Merged
valstu added a commit that referenced this issue Mar 29, 2022
@valstu
Merge pull request #150 from eqlabs/feat/fix-newlines
e064251 
Fixes issue #86 again, regressed in #107 for Firefox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valstu valstu

Labels
flow: test Hook testing phase specific features & epics type: enhancement And enhancement or proposal to an existing feature
Projects
None yet
Milestone
No milestone
4 participants
@vbar @valstu @jonijuup @muzam1l