Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: running Payment is enabled as soon as a source account is selected #85

Open
vbar opened this issue Feb 7, 2022 · 2 comments
Open
Labels
idea/backlog Something to consider later on, maybe type: enhancement And enhancement or proposal to an existing feature

Comments

@vbar
Copy link
Collaborator

vbar commented Feb 7, 2022

which isn't enough - the transaction also needs the destination account:
params

Other transactions might have the same problem...

@muzam1l
Copy link
Collaborator

muzam1l commented Feb 9, 2022

Well we only treat source account field as requirement to make that Run test button work. We could go in for every transaction type and add info about required fields, but that's unnecessary as log just shows you errors correctly.

@muzam1l muzam1l added the idea/backlog Something to consider later on, maybe label Feb 9, 2022
@vbar
Copy link
Collaborator Author

vbar commented Feb 9, 2022

Well we only treat source account field as requirement to make that Run test button work. We could go in for every transaction type and add info about required fields

Well yes, that's what I'd expect from a high-quality GUI... :-) But yes, until users pay for (even failed) transactions it isn't critical...

@jonijuup jonijuup added the type: enhancement And enhancement or proposal to an existing feature label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea/backlog Something to consider later on, maybe type: enhancement And enhancement or proposal to an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants