Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate new webserver #1722

Merged
merged 89 commits into from
Nov 21, 2024

Conversation

kuznetsss
Copy link
Collaborator

@kuznetsss kuznetsss commented Nov 8, 2024

For #919.
The new web server is not using dosguard yet. It will be fixed by a separate PR.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 63.98210% with 161 lines in your changes missing coverage. Please review.

Project coverage is 71.69%. Comparing base (fc3ba07) to head (a9b55f6).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/web/ng/RPCServerHandler.hpp 31.29% 12 Missing and 78 partials ⚠️
src/app/ClioApplication.cpp 0.00% 45 Missing ⚠️
src/web/ng/impl/ErrorHandling.cpp 90.56% 3 Missing and 2 partials ⚠️
src/web/impl/WsBase.hpp 0.00% 4 Missing ⚠️
src/web/ng/Response.cpp 88.23% 4 Missing ⚠️
src/web/Server.hpp 50.00% 0 Missing and 3 partials ⚠️
src/web/impl/HttpBase.hpp 0.00% 2 Missing ⚠️
src/app/CliArgs.cpp 66.66% 0 Missing and 1 partial ⚠️
src/feed/impl/TransactionFeed.cpp 90.00% 0 Missing and 1 partial ⚠️
src/main/Main.cpp 0.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1722      +/-   ##
===========================================
- Coverage    72.09%   71.69%   -0.40%     
===========================================
  Files          287      292       +5     
  Lines        12160    12483     +323     
  Branches      6177     6357     +180     
===========================================
+ Hits          8767     8950     +183     
- Misses        1785     1847      +62     
- Partials      1608     1686      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Few comments and questions 👍

src/app/ClioApplication.hpp Show resolved Hide resolved
src/util/CoroutineGroup.cpp Outdated Show resolved Hide resolved
src/web/AdminVerificationStrategy.cpp Outdated Show resolved Hide resolved
src/web/interface/ConnectionBase.hpp Outdated Show resolved Hide resolved
src/web/ng/Connection.hpp Show resolved Hide resolved
src/web/ng/RPCServerHandler.hpp Show resolved Hide resolved
src/web/ng/Response.cpp Show resolved Hide resolved
src/web/ng/Response.hpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor !

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@kuznetsss kuznetsss merged commit c77154a into XRPLF:develop Nov 21, 2024
17 checks passed
@kuznetsss kuznetsss deleted the 919_Integrate_webserver branch November 21, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants