Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(character): add support for fetching a character and it's ID's in one call #33

Open
1 of 6 tasks
ReidWeb opened this issue Jan 21, 2022 · 0 comments
Open
1 of 6 tasks

Comments

@ReidWeb
Copy link
Member

ReidWeb commented Jan 21, 2022

Description

We need to fetch a characters mounts and minions if they have them.

It's important this incorporates in the ability to inject the cache lookup service.

Use Case

As a consumer of the lodestone module I should be able to request a character, and it's minions with 1 call. In fact this should be the default behaviour.

Proposed Solution

  • characters with no mounts should not incur a /mounts fetch operation
  • characters with no minions should not incur a /minions fetch operation
  • minion/mount id against injected service matching interface should be leveraged
  • option to return only ids should be available

Other information

Relates to #22 , #24 , #23

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant