Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a feature to highlight the word on the searched page #59

Open
Droyk opened this issue Jan 16, 2017 · 15 comments
Open

Implement a feature to highlight the word on the searched page #59

Droyk opened this issue Jan 16, 2017 · 15 comments

Comments

@Droyk
Copy link

Droyk commented Jan 16, 2017

As the title says implement a feature to highlight the word on the searched page like when a user press ctrl+f and then write a word on it, it automatically highlight all the matching words...

thanx for reading


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@blackforestboi
Copy link
Member

Also in the making with the web results view.
Will keep you posted via this issue!

Thanks for letting us know about your ideas.

@Droyk
Copy link
Author

Droyk commented Jan 16, 2017

Ohh music to my ears thanx oliver for such a fast response may I know the approx release date of your next features release.

@blackforestboi
Copy link
Member

can't promise too much at this point, would say approximately 1-2 months. That's because we also undergo some restructuring of the code at the moment.

@Droyk
Copy link
Author

Droyk commented Jan 16, 2017

okay will wait.

@blackforestboi blackforestboi changed the title [Feature Request] Implement a feature to highlight the word on the searched page Implement a feature to highlight the word on the searched page Jan 16, 2017
@blackforestboi
Copy link
Member

blackforestboi commented Jan 16, 2017

Oh I just see I have misread a little bit. I was thinking about in the search results.

But this is an awesome awesome awesome feature request in any case. Will keep this in mind :)

Here I can't promise anything though, as it is really a very detailed feature and is on the near roadmap due to priority reasons. Let's see what can be done though...

@Droyk
Copy link
Author

Droyk commented Jan 16, 2017

Oh I just see I have misread a little bit.

it's okay but What do you mean you misread a little bit what did you actually thought what I am asking?

@blackforestboi
Copy link
Member

what did you actually thought what I am asking?

To highlight the searched words in the search results

@Droyk
Copy link
Author

Droyk commented Jan 16, 2017

Well that's what I am asking .... let's stop for a minute what you are thinking rightnow on what do I actually want?

@blackforestboi
Copy link
Member

Sorry for the confusion :)

I think you are asking for the searched words to be highlighted on the searched page as soon as you enter it, as if you would do cmd+f when you actually are on the page.

I initially read it as you want to have it highlighted in the actual result list....similar to on a google results page, where the searched words are bolded.

@Droyk
Copy link
Author

Droyk commented Jan 16, 2017

Ohh I like both of them

I really never thought anything of bolding the search words in the actual result list +1 from me oliver
now I really like to see it happening.

  • bolded search result like google result page ETA: to be announced
  • highlight the searched words in the search results ETA: 1 to 2 months

@blackforestboi
Copy link
Member

blackforestboi commented Jan 16, 2017

:)

Thanks for structuring it. I would switch the ETAs though:

  • bolded search result like google result page ETA: 1 to 2 months
  • highlight the searched words in the (page of the actual) search result ETA: to be announced

@Droyk
Copy link
Author

Droyk commented Jan 16, 2017

okay but you said above

Here I can't promise anything though, as it is really a very detailed feature and is on the near roadmap due to priority reasons. Let's see what can be done though...

was that for highlight the searched words in the search results like ctrl+f does if yes then I think we both got confused I was asking you the same thing all along I never asked for bolded search result like google hope this solves the confusion.😓

@blackforestboi
Copy link
Member

yeah that was my misreading.
So the highlighting on the page like cmd+f I don't know when it is happening, although i really love this feature idea. Its technically not trivial and is a very detailed feature. Right now we have to focus on providing you with the features that have the most leverage to increase productivity.

The highlighting like google results comes rather early because it is natively supported by the new search engine we just built in. (PouchDB Quick-Search)

@Droyk
Copy link
Author

Droyk commented Jan 16, 2017

don't worry I can and will wait for the highlighting feature to get implemented and by the way where is the roadmap this https://github.com/WorldBrain/START-HERE/blob/master/ROADMAPS.md page is saying 404

@blackforestboi
Copy link
Member

thanks! A new version is currently in the making, should remove the link until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants