Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters selection countering issue #247

Open
marko-srb opened this issue Oct 12, 2023 · 4 comments
Open

Filters selection countering issue #247

marko-srb opened this issue Oct 12, 2023 · 4 comments
Assignees
Labels
[Status] Needs Design Feedback Feedback is needed on an existing or new component
Milestone

Comments

@marko-srb
Copy link

We have a logic issue in the preivew/counters.

Under any filter, we have counters for two different logics:

  1. For each individual tag (Art), or category (Business) we have a counter of 'how many sites' there are under this selected option
  2. For each filter, we have a counter of how many individual tags are applied.

These are two different logics and are confusing. I know we had feedbacks like the following:

a. We need counter of the choices selected for each filter, next to Apply, due accessibility reasons.
b. People then think those represent number of websites.

In my attempt to solve the issue, I tried putting a black box behind the number, which indicates the same visual element as the one that previews number of selected choices once the filter modal is closed. I am not happiest with this solution, but it seems the only one that is working better than what we have (suggestion 2 from the screenshot). If you have any other ideas, please put them here. Otherwise, I maybe would suggest we remove the website counters all together...

I also tried to find similar behavior among complex filtering mechanism on various sites and couldn't find one where both logics are present at the same time.

filtering-numbers-issue

CC: @jasmussen , @fcoveram , @ndiego

@marko-srb marko-srb added the [Status] Needs Design Feedback Feedback is needed on an existing or new component label Oct 12, 2023
@marko-srb marko-srb self-assigned this Oct 12, 2023
@jasmussen
Copy link

I agree, the logic is confusing. The numbers are confusing not just because they denote different counts (tags vs. filters applied), but also because despite those numbers you can very easily end up in a situation where you have zero results, and there's no number shown for that.

To that end, I don't see the value of having any number at all. I do think that the number on the button itself is meant to indicate that you've selected more than one filter. So if we have to keep that, I'd remove the count next to each tag.

@fcoveram
Copy link

I agree with @jasmussen. The confusion of mixing two logics is bigger than the need to show how many sites users will see. I'm drawn to remove the number in each tag and keep the filters selected in the button.

@ndiego
Copy link
Member

ndiego commented Oct 16, 2023

I agree with @jasmussen. The confusion of mixing two logics is bigger than the need to show how many sites users will see. I'm drawn to remove the number in each tag and keep the filters selected in the button.

Fine with me, but I just want to note that this brings us back to the prior implementation that generated the original user feedback that it was confusing. So we should still keep this issue, or create another, for further explorations in the future.

@ndiego
Copy link
Member

ndiego commented Oct 16, 2023

Let's move forward with reverting the indicators for how many sites in each taxonomy term. We can revisit this issue post-launch. Thanks for all your work on this @renintw 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Design Feedback Feedback is needed on an existing or new component
Projects
None yet
Development

No branches or pull requests

5 participants
@fcoveram @jasmussen @ndiego @marko-srb and others