Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single sites: Add responsive image support to site headers #222

Open
ryelle opened this issue Oct 4, 2023 · 2 comments
Open

Single sites: Add responsive image support to site headers #222

ryelle opened this issue Oct 4, 2023 · 2 comments
Labels
[Component] Backend Anything wp-admin or PHP-related [Component] Theme Templates, patterns, CSS
Milestone

Comments

@ryelle
Copy link
Contributor

ryelle commented Oct 4, 2023

I was navigating around the site on staging and found the single pages were pretty slow to load.

Can we update them? The related sites contribute to the slowness.

Page: https://wordpress.org/showcase-v2/opus-one/
Screenshot 2023-10-04 at 12 09 10 PM

#175 (comment)

@ryelle ryelle added [Component] Theme Templates, patterns, CSS [Component] Backend Anything wp-admin or PHP-related labels Oct 4, 2023
@ryelle ryelle self-assigned this Oct 4, 2023
@ryelle ryelle moved this to 📋 To do in WordPress.org Oct 4, 2023
ryelle added a commit that referenced this issue Oct 4, 2023
@ryelle
Copy link
Contributor Author

ryelle commented Oct 4, 2023

@StevenDufresne I've added responsive image hints to the site header & homepage hero, but on most desktop screen sizes you'll still get the biggest image, so I think your other issue for optimizing those would be best.

The Related Sites were already using the responsive image hints, so no change needed there. Is your screen DPR >2? Those images are a max of 533px wide, but it looks like it's loading the 1400 width — for me, with a 2x screen, I get the 1100 wide images, which are at least in the 340-500 kB range. They also shouldn't be loaded until you scroll down to them (lazy loading).

@ryelle
Copy link
Contributor Author

ryelle commented Oct 4, 2023

Forgot to add— I'm leaving this issue open because I don't feel like the fix in 0fdc2ad really addressed the problem, so if there are other ideas this could be the place to brainstorm. But maybe the simplest answer is just to figure out image optimization #219.

@ryelle ryelle removed this from WordPress.org Oct 4, 2023
@ryelle ryelle added this to the Future milestone Oct 4, 2023
@ryelle ryelle removed their assignment Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Backend Anything wp-admin or PHP-related [Component] Theme Templates, patterns, CSS
Projects
None yet
Development

No branches or pull requests

2 participants
@ryelle and others