-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CTA "View All Sites" on results #205
Comments
This might not be as easy as it seems, since the same template is used for the All Sites page as is used for filtered results. Unless you specifically mean search results? (as in for a search term, not tag/category/flavor results). |
Oh, then that's a thing to re-think. I wanted to avoid 'all sites' as the CTA would be weird then. Why? User clicks on View all sites on home page, and then they have the same CTA on bottom of 'All Sites'. Hence I wanted to avoid that. @jasmussen, @ndiego when you get time let me know what you think. |
I see where you are coming from. I think if it were trivial, I'd support it, but it sounds like it's non trivial in which case it also seems fine to omit it. What do you think? |
I would consider this a "nice to have", but not required for launch. There is the "View all sites" link in the sub-nav |
Should we close this issue, then? |
I think this isn't needed for launch, hence the response was missing. Let's leave the issues open + needs design, which aren't ready for launch, nor needed. I'll put 'needs design feedback' + 'low priority' labels on such issues. |
I've removed it from the project and put it in the "Future" milestone. |
Can we add CTA "View All Sites" on results?
The text was updated successfully, but these errors were encountered: