Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CTA "View All Sites" on results #205

Open
marko-srb opened this issue Sep 28, 2023 · 7 comments
Open

Add CTA "View All Sites" on results #205

marko-srb opened this issue Sep 28, 2023 · 7 comments
Labels
[Component] Theme Templates, patterns, CSS priority: low This should happen sometime, but other things are more important [Status] Needs Design Feedback Feedback is needed on an existing or new component
Milestone

Comments

@marko-srb
Copy link

Can we add CTA "View All Sites" on results?

image

@ryelle
Copy link
Contributor

ryelle commented Sep 28, 2023

This might not be as easy as it seems, since the same template is used for the All Sites page as is used for filtered results. Unless you specifically mean search results? (as in for a search term, not tag/category/flavor results).

@ryelle ryelle added the [Component] Theme Templates, patterns, CSS label Sep 28, 2023
@ryelle ryelle moved this to ⚠ On Hold/Blocked in WordPress.org Sep 28, 2023
@ryelle ryelle added the [Status] Needs Design Feedback Feedback is needed on an existing or new component label Sep 28, 2023
@marko-srb
Copy link
Author

Oh, then that's a thing to re-think. I wanted to avoid 'all sites' as the CTA would be weird then. Why? User clicks on View all sites on home page, and then they have the same CTA on bottom of 'All Sites'. Hence I wanted to avoid that.

Originally, I wanted it only for 'typed search results'. But now, if we make the sub-nav with links sticky, I am not sure if we even need this CTA anywhere, except home page.

@jasmussen, @ndiego when you get time let me know what you think.

@jasmussen
Copy link

I see where you are coming from. I think if it were trivial, I'd support it, but it sounds like it's non trivial in which case it also seems fine to omit it. What do you think?

@ndiego
Copy link
Member

ndiego commented Sep 29, 2023

I would consider this a "nice to have", but not required for launch. There is the "View all sites" link in the sub-nav

@ryelle
Copy link
Contributor

ryelle commented Sep 29, 2023

Should we close this issue, then?

@marko-srb
Copy link
Author

marko-srb commented Oct 3, 2023

I think this isn't needed for launch, hence the response was missing.

Let's leave the issues open + needs design, which aren't ready for launch, nor needed. I'll put 'needs design feedback' + 'low priority' labels on such issues.

@marko-srb marko-srb added the priority: low This should happen sometime, but other things are more important label Oct 3, 2023
@ryelle ryelle added this to the Future milestone Oct 3, 2023
@ryelle ryelle removed this from WordPress.org Oct 3, 2023
@ryelle
Copy link
Contributor

ryelle commented Oct 3, 2023

I've removed it from the project and put it in the "Future" milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS priority: low This should happen sometime, but other things are more important [Status] Needs Design Feedback Feedback is needed on an existing or new component
Projects
None yet
Development

No branches or pull requests

5 participants
@ryelle @jasmussen @ndiego @marko-srb and others