-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search results / Title design options #203
Comments
Icons: These could be hard-coded in CSS, since there are few categories. We would just need all icon SVGs uploaded to this issue before dev work could start. Any icon changes would then require dev work. If you want an editor to be able to change them, there are more considerations around how that would work - we can add a field to each term, but can an editor upload any image? choose from a set? they can't upload SVGs to the site (a core security thing), so the icons would need to be raster images… and so on. Text: Is the text here meant to be a heading? We already had some discussion in #180 for how to handle the main heading here (invisible currently), and landed on a format of "Filtered by: Sports" so that it could incorporate multiple filters, like "Filtered by: Sports, WordPress.org". See #193 where this was implemented. Also cc @eidolonnight @thetinyl who had comments on that issue. Ideally we would use the same heading for screen reader users and visible text. How would this heading handle when multiple filters are applied? |
Needs Design input. Will do some tests to see what can be done here... Thanks! |
I've moved this out of the project and into the Future milestone, but really it seems like this would be better off closed unless the idea comes back up again. As you mention, the current page info is listed in the breadcrumbs, and also there is already a visually hidden main heading for a11y & SEO (see #193). |
I have made a few iterations of the title options we could use for the specific category search.
Design review by: @jasmussen and DC (message shared on Slack)
The text was updated successfully, but these errors were encountered: