Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results / Title design options #203

Open
marko-srb opened this issue Sep 28, 2023 · 6 comments
Open

Search results / Title design options #203

marko-srb opened this issue Sep 28, 2023 · 6 comments
Labels
priority: low This should happen sometime, but other things are more important [Status] Needs Design Feedback Feedback is needed on an existing or new component [Status] Needs Design Design is needed before implementation can start
Milestone

Comments

@marko-srb
Copy link

I have made a few iterations of the title options we could use for the specific category search.

  1. Are all of these doable, if any?
  2. Design review needed.

results-categories-WIP

Design review by: @jasmussen and DC (message shared on Slack)

@marko-srb marko-srb added the [Status] Needs Design Feedback Feedback is needed on an existing or new component label Sep 28, 2023
@ndiego
Copy link
Member

ndiego commented Sep 28, 2023

From a dev perspective, there would require some custom block work. I am also a bit hesitant about the icon and image since we would need to assign an icon/image for every taxonomy (tag, category, flavor). Perhaps for the initial launch, we just stick to a simple title?

Also note that the "# sites" next to the search box will display the current number of sites in the query. So the number of sites in the parenthesis is a bit redundant.

image

@marko-srb
Copy link
Author

marko-srb commented Sep 28, 2023

Good catch.

About the icons thing. I don't think we need them for anything other than categories at the moment, but lets learn as we go. For tags, especially never. But let's chat about this more and see if this is left for later or a minor thing could be done now.

Here are next suggestions:
image

@ryelle
Copy link
Contributor

ryelle commented Sep 28, 2023

Icons: These could be hard-coded in CSS, since there are few categories. We would just need all icon SVGs uploaded to this issue before dev work could start. Any icon changes would then require dev work. If you want an editor to be able to change them, there are more considerations around how that would work - we can add a field to each term, but can an editor upload any image? choose from a set? they can't upload SVGs to the site (a core security thing), so the icons would need to be raster images… and so on.

Text: Is the text here meant to be a heading? We already had some discussion in #180 for how to handle the main heading here (invisible currently), and landed on a format of "Filtered by: Sports" so that it could incorporate multiple filters, like "Filtered by: Sports, WordPress.org". See #193 where this was implemented. Also cc @eidolonnight @thetinyl who had comments on that issue. Ideally we would use the same heading for screen reader users and visible text.

How would this heading handle when multiple filters are applied?

@ryelle ryelle moved this to 🛑 Pending discussion in WordPress.org Sep 28, 2023
@marko-srb
Copy link
Author

Needs Design input. Will do some tests to see what can be done here... Thanks!

@marko-srb marko-srb added the [Status] Needs Design Design is needed before implementation can start label Sep 29, 2023
@ryelle ryelle moved this from 🛑 Pending discussion to ⚠ On Hold/Blocked in WordPress.org Oct 2, 2023
@marko-srb
Copy link
Author

Once we have breadcrumbs it seems that having these is not needed, as the same info / links are then in 3 different places (see screenshot). Therefore, I'd leave this issue open, and up for rethinking after the launch.

Screen Shot 2023-10-03 at 14 03 48

@marko-srb marko-srb added the priority: low This should happen sometime, but other things are more important label Oct 3, 2023
@ryelle ryelle removed this from WordPress.org Oct 3, 2023
@ryelle ryelle added this to the Future milestone Oct 3, 2023
@ryelle
Copy link
Contributor

ryelle commented Oct 3, 2023

I've moved this out of the project and into the Future milestone, but really it seems like this would be better off closed unless the idea comes back up again. As you mention, the current page info is listed in the breadcrumbs, and also there is already a visually hidden main heading for a11y & SEO (see #193).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low This should happen sometime, but other things are more important [Status] Needs Design Feedback Feedback is needed on an existing or new component [Status] Needs Design Design is needed before implementation can start
Projects
None yet
Development

No branches or pull requests

4 participants
@ryelle @ndiego @marko-srb and others