-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style updates of headings #24
Comments
@fcoveram The photo details headings are "Heading 6" size, but with this update, they're smaller than the body text. The "Heading 5" size is also slightly smaller. For example, these use "Heading 5" and "Heading 6" in the desktop mockups, here's what they look like with the new small fonts. Is this correct?
|
Do you know if using the same font size for Heading 5 and 6 meets accessibility requirements? I looked at the WCAG and found nothing related to show size differences between headings. Since font sizes on mobile are already small from heading 3 in Inter, keeping them small compared to the body looks strange. If there is no problem with requirements, then both headings in 16px seem fine to me. Thoughts @jasmussen? |
I believe it's a best practice to have some visual differentiation between each heading level, but not a requirement as such. The requirement is that they are correct in their semantics, h1 > h2 > h3, etc, not h1 > h3 > h2. To that end, I think both headings in 16px should work. But otherwise, we could look at a different visual treatment, for example all-caps for the smaller level. |
All-caps is also not recommended for accessibility reasons - like above, there's no wcag requirement, but uppercase text is uniform in shape, so it's arguably harder for users with dyslexia, and not suited to long headings for everyone. There's a good discussion on all-caps in core Drupal themes with references, where someone also made the point that in languages that don't have an uppercase (e.g., Japanese), using case to differentiate headings would do nothing. Anyway, uppercase could work here since the use case is only very few words, and this site is not available in other languages yet — but I'm not sure about introducing a style that has potential issues into the design system, unless it's emphasized somewhere that it should only be for 1-2 word headings (and so never used on user-generated text). |
Thanks for that input. I was trying to keep the same x-height between Inter and EB Garamond headings, but perhaps I can move away from that idea and distribute sizes between Headings 3 and 6 more evenly. I made a quick mockup and the following sizes could work.
The rest of the font properties remain as proposed in the initial comment. |
Derived from this comment and ticket wporg-parent-2021#163
Text style update
Add the mobile versions of headings in Inter. That spans Heading 3, 4, 5, and 6, as documented in the Design Library's styles page.
The text was updated successfully, but these errors were encountered: