-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How should we handle i18n for FSE templates? #19
Comments
Ah this is good to know. In that case, I would guess that updating the design on rosetta sites would be a separate project. I would lean towards not worrying about translations for this project right now. There won't be a ton of strings, so it hopefully wouldn't be hard to add in translations once GB supports them. |
That sounds good to me 👍🏻 |
Re-opening since we'll want to do this eventually, but moving it to the farthest-away milestone. Maybe blocked by #13. We'll probably want to move this to the parent theme repo, and then backport to News. |
We can use block patterns for this. Check how Blockbase does it for the 404 pages while hiding the block pattern from the users in the editor. |
Yeah, that could be an acceptable workaround in the meantime, but I'm hoping one of the Gutenberg tickets above will provide something analogous to how PHP/JS files are translated. IMO that'd be a much better solution. |
From my experience and what I've talked with other GB contributors I don't think that's happening any time soon and it's not something easy to solve or clear as to how to do so |
It sounds like blockbase had to create PHP templates
...and TwentyTwentyTwo had to create patterns.
those may be good arounds for us too, but still seems pretty hacky. it doesn't sound like gutenberg really supports i18n yet.
will that be an issue when we launch this? i guess we'd continue using the old theme on rosetta sites anyway, since those just use the
main
theme for the entire site, rather than having a separate WP site for the blog.The text was updated successfully, but these errors were encountered: