Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multisite Support #64

Open
Sephsekla opened this issue Jul 21, 2021 · 7 comments
Open

Multisite Support #64

Sephsekla opened this issue Jul 21, 2021 · 7 comments
Labels
[Scope] Database / Persistence Issue related to storing data. To WP database or another location. [Type] Research Information that need to be gathered before execution.

Comments

@Sephsekla
Copy link
Collaborator

Do we have a plan in place for how notifications will be handled on a multisite installation? It would be great to be able to see notifications from multiple sites in a network in one place. Maybe on a multisite install we could add an extra indicator to each notification to show which site it refers to.

@raaaahman
Copy link
Collaborator

raaaahman commented Jul 21, 2021

This is probably tied to the recipients. Only the super admin role should be notified about actions happening on every sites.

Maybe on a multisite install we could add an extra indicator to each notification to show which site it refers to.

Yes, probably.

Maybe there is also the severity to take into account: should we notify the super admin about any matter that is less than critical for other sites of the network?

In the end, if it is a matter of only warning the super admin about critical failures in the network, then this could be a feature we can add later rather than defining a characteristic of the system.

@Sephsekla
Copy link
Collaborator Author

In an ideal world it would be good to have an option to configure that - I'm not sure there's a right answer as opposed to just case by case preferences. It could be a dashboard setting, or even just a filter to start with.

@jonathanbossenger
Copy link
Collaborator

Is it possible that what we have currently is sufficient for a multisite network?

The notification originator (core, plugin, theme) can determine a) if this is a multisite network and b) who the super admin is, and create a notification for them. The notification originator can then include a) whether this notification pertains to the network, or a specific site, and b) if needed, the specific site it pertains to, either by adding this to the title or message for the notification.

Given this, are there any situations we can think of where what we have available in the notification schema would not be enough for a multisite-related notification?

@raaaahman
Copy link
Collaborator

The notification originator (core, plugin, theme) can determine a) if this is a multisite network and b) who the super admin is, and create a notification for them. The notification originator can then include a) whether this notification pertains to the network, or a specific site, and b) if needed, the specific site it pertains to, either by adding this to the title or message for the notification.

The origin site information could indeed pertain in the Sender model. But that would still need to be added to the current Sender model.

@Sephsekla
Copy link
Collaborator Author

It may be that it's mainly a frontend display consideration then. I think these are the key points to consider:

  • Do we show notifications for all sites everywhere? Only on their own site? In network admin?
  • How do we easily distinguish between notifications from different sites? Do we group them?
  • How configurable are all these decisions by the end user (in a settings ui or to start with just filters or flags)?

@folletto
Copy link
Collaborator

Here's a basic idea that I think fits very well the model.

  • The in-hub notifications are multi-site
  • The in-page notifications are site-specific

Both are determined by the specific notification level on the originating site: if the site delivers a in-hum notification to a specific user role, then it will be delivered regardless of site.

I think this can be later be reviewed, but I think it's the baseline starting point we can ship, then refine.

One thing design wise that comes out of it is that on multi-site installation we might need to review how clear it is the site source. Might already work with what we have, but definitely something to check.

@Sephsekla
Copy link
Collaborator Author

This was raised again when I demoed the POC plugin last week. We discussed the possibility of a select/filter control for notification source, so this could tie together nicely #84

@Sephsekla Sephsekla added the [Scope] Database / Persistence Issue related to storing data. To WP database or another location. label Jun 13, 2022
@Sephsekla Sephsekla added the [Type] Research Information that need to be gathered before execution. label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Scope] Database / Persistence Issue related to storing data. To WP database or another location. [Type] Research Information that need to be gathered before execution.
Projects
None yet
Development

No branches or pull requests

4 participants