Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the Sender as parameter to the Factory #40

Open
raaaahman opened this issue Jan 18, 2021 · 0 comments
Open

Pass the Sender as parameter to the Factory #40

raaaahman opened this issue Jan 18, 2021 · 0 comments
Assignees
@danbilauca
Labels
[Scope] Service The core logic of the WP Notify project. [Status] Blocked When another issue need to be taken care of first. [Type] Feature Describe a feature to be added to the project

Comments

@raaaahman
Copy link
Collaborator

raaaahman commented Jan 18, 2021 •
edited
Loading

We should replace the following line to use a Sender instance from a Factory property instead:

https://github.com/WordPress/wp-notify/blob/3b5fca5d3b09cf820a9a2e5534113ea629d4342d/includes/Factory.php#L43

This would allow each plugin or theme to be identified as sender of notifications.

blocked by #41
@raaaahman raaaahman added [Type] Feature Describe a feature to be added to the project [Scope] Service The core logic of the WP Notify project. labels Jan 18, 2021
@raaaahman raaaahman added the [Status] Blocked When another issue need to be taken care of first. label Jan 18, 2021
@danbilauca danbilauca self-assigned this Feb 18, 2021
danbilauca added a commit that referenced this issue Feb 19, 2021
@danbilauca
#40 Sender instance passed to the Factory
c9b8a2a
raaaahman pushed a commit that referenced this issue Mar 2, 2021
@danbilauca
#40 Sender instance passed to the Factory
33bf5b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danbilauca danbilauca

Labels
[Scope] Service The core logic of the WP Notify project. [Status] Blocked When another issue need to be taken care of first. [Type] Feature Describe a feature to be added to the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danbilauca @raaaahman