Add a 'View in code editor' link to the PHPCS warnings/errors

[EvanHerman]

Closes #251

Description of the Change

As outlined in the issue linked below, this PR conditionally displays a View in code editor link beneath each PHPCS warning/error so users can make changes to their code in the code editor in the WordPress dashboard.

Open files in external IDE

Editing files can be done in an external editor using the supplied plugin_check_validation_error_source_file_editor_url_template filter.

Examples:

PhpStorm

add_filter( 'plugin_check_validation_error_source_file_editor_url_template', function () {
    return 'phpstorm://open?file={{file}}&line={{line}}';
} );

VS Code

add_filter( 'plugin_check_validation_error_source_file_editor_url_template', function () {
    return 'vscode://file/{{file}}:{{line}}';
} );

How to test the Change

Run the Plugin Check (from this branch) on any plugin with a PHPCS warning or error and click on the 'View in code editor' to be brought over to the plugin file editor. Once there, confirm that the editor scrolls down to (and highlights) the correct line.

Changelog Entry

Added - 'View in code editor' link beneath each PHPCS error or warning.

Credits

Props @westonruter, @felixarntz, @mukeshpanchal27, @bordoni

Checklist:

• I agree to follow this project's Code of Conduct.
• I have added tests to cover my change.
• All new and existing tests pass.

[bordoni]

Added some changes to make the logic easier to read, do you mind adding a Changelog to the readme.txt?

[westonruter]

This will need to be translated at some point.

[bordoni]

Oh that is a great catch too, I will handle that in a separate PR.

[mukeshpanchal27]

Thanks @EvanHerman for the PR. Left some feedback.

This PR closed the original issue but make sure we have to update it in trunk so we will get this for future version.

[felixarntz]

@EvanHerman @bordoni A general question not specifically about this change: I see this is targeting legacy-plugin, what about the trunk branch?

I would like to better understand what your current plans are with the "legacy plugin", because I thought it was about publishing only a 0.2. Since this PR is an enhancement and not a bug fix, I'm curious whether you plan to do further releases based on that codebase? I want to be mindful of us not duplicating too much work, and I think switching sooner than later will help with that.

[bordoni]

@felixarntz 100% in agreement there, I will create a Ticket for me to port this functionality to the trunk version once it comes time to port the Legacy code into the new plugin.

[felixarntz]

@EvanHerman This looks good, just one important change needed (permissions check).

[felixarntz]

This is awesome 👍

[westonruter]

Inline after script goodness! 😄

Source: https://github.com/ampproject/amp-wp/blob/956c8d298764e4b22b936347d7c8b591b2fadfc2/includes/validation/class-amp-validation-error-taxonomy.php#L1034-L1062