Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce slug argument in CLI #650

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Introduce slug argument in CLI #650

merged 4 commits into from
Sep 20, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Sep 19, 2024 •
edited
Loading

Fixes #644

@ernilambar ernilambar force-pushed the 644-cli-slug-argument branch 5 times, most recently from 81241e8 to f740555 Compare September 20, 2024 05:07
@ernilambar ernilambar marked this pull request as ready for review September 20, 2024 05:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: dd32 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar force-pushed the 644-cli-slug-argument branch from f740555 to 6f80489 Compare September 20, 2024 05:41
@davidperezgar davidperezgar mentioned this pull request Sep 20, 2024
Closed
@davidperezgar
Copy link
Member

@ernilambar did you test it the i18n?

@ernilambar
Copy link
Member Author

@ernilambar did you test it the i18n?

No. We can implement it in other checks later after proper slug is available.

mukeshpanchal27
mukeshpanchal27 previously requested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR introduce the warning textdomain_mismatch for AJAX runner. It return wrong slug for plugin.

Screenshot 2024-09-20 at 12 31 36 PM

Make sure to add unit tests this scenario if possible

@ernilambar
Copy link
Member Author

PR has been updated.

@swissspidy swissspidy mentioned this pull request Sep 20, 2024
Closed
@swissspidy swissspidy added this to the 1.2.0 milestone Sep 20, 2024
@swissspidy swissspidy dismissed mukeshpanchal27’s stale review September 20, 2024 16:12

Feedback has been addressed

@davidperezgar davidperezgar mentioned this pull request Sep 20, 2024
Closed
@ernilambar ernilambar added the Infrastructure Issues for the overall plugin infrastructure label Sep 20, 2024
@ernilambar ernilambar added the WP-CLI Issues related to WP-CLI label Sep 20, 2024
@ernilambar ernilambar merged commit 3fba091 into trunk Sep 20, 2024
22 checks passed
@ernilambar ernilambar deleted the 644-cli-slug-argument branch September 20, 2024 17:42
@ernilambar ernilambar mentioned this pull request Sep 22, 2024
Merged
bazza pushed a commit to WordPress/wordpress.org that referenced this pull request Sep 24, 2024
@dd32
Plugin Directory: Plugin Check: Pass the slug to plugin check.
45e3ee6 
Props rabmalin.
See WordPress/plugin-check#650.
See #7778.


git-svn-id: https://meta.svn.wordpress.org/sites/trunk@14074 74240141-8908-4e6f-9713-ba540dce6ec7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidperezgar davidperezgar davidperezgar approved these changes

@swissspidy swissspidy swissspidy approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 left review comments

@barrykooij barrykooij Awaiting requested review from barrykooij barrykooij is a code owner

@frantorres frantorres Awaiting requested review from frantorres frantorres is a code owner

Assignees
No one assigned
Labels
Infrastructure Issues for the overall plugin infrastructure WP-CLI Issues related to WP-CLI
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

New parameter in CLI to specify the correct slug
4 participants
@ernilambar @davidperezgar @swissspidy @mukeshpanchal27