Allow parameter force-slug #645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidperezgar
requested review from
ernilambar,
swissspidy and
mukeshpanchal27
ernilambar
reviewed
Sep 19, 2024
|
|
||
| global $argv; | ||
| $slug_prefix = '--force-slug='; | ||
| $result = array_filter( |
There was a problem hiding this comment.
I not liking this approach of fetching global arguments inside the check. May be we should save this new slug globally with which we can access from any checks. We need this value in other checks also.
There was a problem hiding this comment.
Ok, How could I make it?
|
I see that @ernilambar approach is better than mine in the PR #650 . So Let's close it! |
ernilambar
deleted the
644-new-parameter-in-cli-to-specify-the-correct-slug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #644 and it's related with PR #480
This is a first approach to solve this issue. It works.
What I see is that phpcs allows to force the text_domain with a slug. It can be done like explained here with the parameters:
--runtime-set text_domain desired-slugSo, we need to allow a new argument in PHPCS, and set the slug to check.