Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fetch with wp.ajax.post #639

Closed
wants to merge 2 commits into from
Closed

Replace fetch with wp.ajax.post #639

wants to merge 2 commits into from

Conversation

chriscct7
Copy link
Member

@chriscct7 chriscct7 commented Sep 17, 2024 •
edited
Loading

Fixes #125

This PR was written by AI and has not been reviewed yet for accuracy

For more details, open the Copilot Workspace session.

@chriscct7
Replace fetch with wp.ajax.post
dacdd97 
Fixes #125

This PR was written by AI and has not been reviewed yet for accuracy

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/WordPress/plugin-check/issues/125?shareId=XXXX-XXXX-XXXX-XXXX).
@WordPress WordPress deleted a comment from github-actions bot Sep 18, 2024
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: chriscct7 <[email protected]>
Co-authored-by: ernilambar <[email protected]>
Co-authored-by: felixarntz <[email protected]>
Co-authored-by: spacedmonkey <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@chriscct7
Copy link
Member Author

@ernilambar make sure you review this one thoroughly. We were testing an AI tool at Contributors Day that wrote the pr.

@ernilambar
Copy link
Member

I tested this in my local setup and it is not working. Instead of returning data from AJAX, we get only Promise object.

@chriscct7
Copy link
Member Author

Sounds good. I'll close this so we don't accidentally merge it

@chriscct7 chriscct7 closed this Sep 19, 2024
@ernilambar ernilambar deleted the chriscct7/replace-fetch-with-wp-ajax-post branch September 25, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace fetch with wp.ajax.post
2 participants
@chriscct7 @ernilambar