reverted tests and updated escaped default

WordPress · Dec 6, 2024 · 2ce79b0 · 2ce79b0
1 parent c5e3bdc
commit 2ce79b0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/includes/Checker/Checks/General/I18n_Usage_Check.php b/includes/Checker/Checks/General/I18n_Usage_Check.php
@@ -99,7 +99,7 @@ public function get_documentation_url(): string {
 	 */
 	protected function add_result_message_for_file( Check_Result $result, $error, $message, $code, $file, $line = 0, $column = 0, string $docs = '', $severity = 5 ) {
 		// Downgrade errors about usage of the 'default' text domain from WordPress Core to warnings.
-		if ( $error && str_ends_with( $message, " but got 'default'." ) ) {
+		if ( $error && str_ends_with( $message, " but got &#039;default&#039;." ) ) {
 			$error = false;
 		}
 

diff --git a/tests/phpunit/tests/Checker/Checks/I18n_Usage_Check_Tests.php b/tests/phpunit/tests/Checker/Checks/I18n_Usage_Check_Tests.php
@@ -58,8 +58,8 @@ public function test_run_without_default_textdomain() {
 
 		// Explicitly using the 'default' text domain is a warning, omitting a text domain is an error.
 		$this->assertNotEmpty( $check_result->get_errors() );
-		$this->assertEmpty( $check_result->get_warnings() );
-		$this->assertEquals( 2, $check_result->get_error_count() );
-		$this->assertEquals( 0, $check_result->get_warning_count() );
+		$this->assertNotEmpty( $check_result->get_warnings() );
+		$this->assertEquals( 1, $check_result->get_error_count() );
+		$this->assertEquals( 1, $check_result->get_warning_count() );
 	}
 }