From 09dad210cf6c16a7b4c4dc1d5432459df553eb10 Mon Sep 17 00:00:00 2001 From: Nilambar Sharma Date: Mon, 18 Nov 2024 21:26:54 +0545 Subject: [PATCH] Bump min php support to 7.4 --- .github/workflows/behat-test.yml | 4 +--- .github/workflows/php-test.yml | 5 +---- CONTRIBUTING.md | 2 +- composer.json | 4 ++-- phpcs-sniffs/composer.json | 6 +++--- phpcs-sniffs/phpcs.xml.dist | 2 +- phpcs.xml.dist | 2 +- plugin.php | 4 ++-- 8 files changed, 12 insertions(+), 17 deletions(-) diff --git a/.github/workflows/behat-test.yml b/.github/workflows/behat-test.yml index de9b8c633..85e664fb6 100644 --- a/.github/workflows/behat-test.yml +++ b/.github/workflows/behat-test.yml @@ -60,8 +60,6 @@ jobs: fail-fast: true matrix: php: - - '7.2' - - '7.3' - '7.4' - '8.0' - '8.1' @@ -70,7 +68,7 @@ jobs: - php: '8.2' wordpress: 'latest' coverage: true - - php: '7.2' + - php: '7.4' wordpress: '6.3' - php: '8.3' wordpress: 'trunk' diff --git a/.github/workflows/php-test.yml b/.github/workflows/php-test.yml index bb7d48eec..03bc69be9 100644 --- a/.github/workflows/php-test.yml +++ b/.github/workflows/php-test.yml @@ -48,13 +48,12 @@ jobs: fail-fast: true matrix: php: - - '7.3' - '7.4' - '8.0' - '8.1' wordpress: [ 'latest' ] include: - - php: '7.2' + - php: '7.4' wordpress: '6.3' - php: '8.2' wordpress: 'latest' @@ -115,8 +114,6 @@ jobs: fail-fast: true matrix: php: - - '7.2' - - '7.3' - '7.4' - '8.0' - '8.1' diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 41a9bd898..6749fea47 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,7 +7,7 @@ Thank you for your interest in contributing to the Plugin Check plugin! In general, all code must follow the [WordPress Coding Standards and best practices](https://developer.wordpress.org/coding-standards/). All code in the Plugin Check plugin must follow these requirements: - **WordPress**: The plugin's minimum WordPress version requirement is 6.3. -- **PHP**: Always match the latest WordPress version. The minimum required version right now is 7.2.24. +- **PHP**: Always match the latest WordPress version. The minimum required version right now is 7.4. ## Guidelines diff --git a/composer.json b/composer.json index e654e06db..d23f2c8a7 100644 --- a/composer.json +++ b/composer.json @@ -4,7 +4,7 @@ "license": "GPL-2.0-or-later", "type": "wordpress-plugin", "require": { - "php": ">=7.2.24", + "php": ">=7.4", "ext-json": "*", "afragen/wordpress-plugin-readme-parser": "dev-master#67fba498d0b112acf84386b95e4905c539a33f0b", "automattic/vipwpcs": "^3.0.0", @@ -56,7 +56,7 @@ "phpstan/extension-installer": true }, "platform": { - "php": "7.2.24" + "php": "7.4" } }, "scripts": { diff --git a/phpcs-sniffs/composer.json b/phpcs-sniffs/composer.json index 321eea251..7258b4dba 100644 --- a/phpcs-sniffs/composer.json +++ b/phpcs-sniffs/composer.json @@ -16,7 +16,7 @@ } ], "require": { - "php": ">=7.2.24", + "php": ">=7.4", "ext-libxml": "*", "ext-tokenizer": "*", "ext-xmlreader": "*", @@ -38,7 +38,7 @@ "dealerdirect/phpcodesniffer-composer-installer": true }, "platform": { - "php": "7.2.24" + "php": "7.4" } }, "scripts": { @@ -67,4 +67,4 @@ "lint": "Lint PHP files against parse errors.", "run-tests": "Run all the unit tests for the Plugin Check Coding Standards sniffs." } -} \ No newline at end of file +} diff --git a/phpcs-sniffs/phpcs.xml.dist b/phpcs-sniffs/phpcs.xml.dist index 337d86812..9f61b589c 100644 --- a/phpcs-sniffs/phpcs.xml.dist +++ b/phpcs-sniffs/phpcs.xml.dist @@ -37,7 +37,7 @@ - + diff --git a/phpcs.xml.dist b/phpcs.xml.dist index 178470c80..436717cd8 100644 --- a/phpcs.xml.dist +++ b/phpcs.xml.dist @@ -3,7 +3,7 @@ Sniffs for WordPress plugins, with minor modifications for Performance - + diff --git a/plugin.php b/plugin.php index 8de444180..a905b6c3d 100644 --- a/plugin.php +++ b/plugin.php @@ -4,7 +4,7 @@ * Plugin URI: https://github.com/WordPress/plugin-check * Description: Plugin Check is a WordPress.org tool which provides checks to help plugins meet the directory requirements and follow various best practices. * Requires at least: 6.3 - * Requires PHP: 7.2.24 + * Requires PHP: 7.4 * Version: 1.2.0 * Author: WordPress Performance Team and Plugin Review Team * License: GPLv2 or later @@ -17,7 +17,7 @@ use WordPress\Plugin_Check\Plugin_Main; define( 'WP_PLUGIN_CHECK_VERSION', '1.2.0' ); -define( 'WP_PLUGIN_CHECK_MINIMUM_PHP', '7.2.24' ); +define( 'WP_PLUGIN_CHECK_MINIMUM_PHP', '7.4' ); define( 'WP_PLUGIN_CHECK_MAIN_FILE', __FILE__ ); define( 'WP_PLUGIN_CHECK_PLUGIN_DIR_PATH', plugin_dir_path( WP_PLUGIN_CHECK_MAIN_FILE ) ); define( 'WP_PLUGIN_CHECK_PLUGIN_DIR_URL', plugin_dir_url( WP_PLUGIN_CHECK_MAIN_FILE ) );