Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a memory leak to check the k6 tests - follow up on #5213 #5214

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Nov 29, 2024

Fixes

Related to #5179 by @obulat

Description

Between the versions of 2.1.7 and 2.2.5, Pinia has fixed the problem that was causing a memory leak when initializing a store from an existing object (probably in fix: reference the store directly in storeToRefs to ensure correct reactivity after HMR). This means that #5179 alone is not enough to introduce a memory leak, we need to downgrade pinia as well.

Testing Instructions

This change will only be used to test k6 in staging, and will be reversed later.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner November 29, 2024 07:51
@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: frontend Related to the Nuxt frontend labels Nov 29, 2024
Copy link

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 6400      ✗ 0   
     data_received..................: 1.5 GB  7.1 MB/s
     data_sent......................: 837 kB  4.0 kB/s
     http_req_blocked...............: avg=14.12µs  min=2.04µs   med=4.45µs   max=7.18ms  p(90)=5.88µs   p(95)=6.32µs  
     http_req_connecting............: avg=9.32µs   min=0s       med=0s       max=7.12ms  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=727.37ms min=44.98ms  med=639.87ms max=2.85s   p(90)=1.29s    p(95)=1.4s    
       { expected_response:true }...: avg=727.37ms min=44.98ms  med=639.87ms max=2.85s   p(90)=1.29s    p(95)=1.4s    
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 6400
     http_req_receiving.............: avg=151.51µs min=44.53µs  med=125.01µs max=19.21ms p(90)=194.65µs p(95)=233.44µs
     http_req_sending...............: avg=23.31µs  min=5.92µs   med=20.3µs   max=4.71ms  p(90)=26.21µs  p(95)=28.01µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=727.19ms min=44.83ms  med=639.71ms max=2.85s   p(90)=1.29s    p(95)=1.4s    
     http_reqs......................: 6400    30.227723/s
     iteration_duration.............: avg=3.88s    min=821.35ms med=3.24s    max=10.31s  p(90)=7.44s    p(95)=7.91s   
     iterations.....................: 1200    5.667698/s
     vus............................: 8       min=8       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat changed the title Introduce a memory leak to test k6 - follow up on #5213 Introduce a memory leak to check the k6 tests - follow up on #5213 Nov 29, 2024
@obulat obulat merged commit 6798610 into main Nov 29, 2024
75 checks passed
@obulat obulat deleted the downgrade-pinia-for-memory-leak branch November 29, 2024 08:05
obulat added a commit that referenced this pull request Nov 30, 2024
@obulat obulat mentioned this pull request Nov 30, 2024
8 tasks
obulat added a commit that referenced this pull request Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: 🤝 Merged
Development

Successfully merging this pull request may close these issues.

1 participant