Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nuxt version #5186

Closed
wants to merge 1 commit into from
Closed

Update Nuxt version #5186

wants to merge 1 commit into from

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Nov 26, 2024

Description

This PR updates Nuxt to the latest version. This version introduces a shared directory for code that is used both by the server and by the client-side app. This will be important for adding server-side cache for media provider stats, and for proxying API requests through the Nuxt server, and will be added in a follow-up PR.

Testing Instructions

The CI should pass, and there should be no additional warnings when running the app.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Nov 26, 2024
@obulat obulat added 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Nov 26, 2024
@obulat obulat self-assigned this Nov 26, 2024
Copy link

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 6400      ✗ 0   
     data_received..................: 1.5 GB  7.8 MB/s
     data_sent......................: 837 kB  4.4 kB/s
     http_req_blocked...............: avg=9.18µs   min=1.97µs   med=4.12µs   max=4.72ms  p(90)=5.43µs   p(95)=5.96µs 
     http_req_connecting............: avg=4.07µs   min=0s       med=0s       max=2.87ms  p(90)=0s       p(95)=0s     
     http_req_duration..............: avg=666.23ms min=90.37ms  med=572.75ms max=3.44s   p(90)=1.2s     p(95)=1.3s   
       { expected_response:true }...: avg=666.23ms min=90.37ms  med=572.75ms max=3.44s   p(90)=1.2s     p(95)=1.3s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 6400
     http_req_receiving.............: avg=160.72µs min=44.06µs  med=123.06µs max=21.3ms  p(90)=191.96µs p(95)=230.2µs
     http_req_sending...............: avg=23.1µs   min=6.55µs   med=20.07µs  max=10.43ms p(90)=25.73µs  p(95)=27.9µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s      p(90)=0s       p(95)=0s     
     http_req_waiting...............: avg=666.04ms min=90.25ms  med=572.58ms max=3.44s   p(90)=1.2s     p(95)=1.3s   
     http_reqs......................: 6400    33.467189/s
     iteration_duration.............: avg=3.56s    min=785.39ms med=2.98s    max=10.01s  p(90)=6.97s    p(95)=7.28s  
     iterations.....................: 1200    6.275098/s
     vus............................: 3       min=3       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

Copy link

Playwright failure test results: https://github.com/WordPress/openverse/actions/runs/12029066356

It looks like some of the Playwright tests failed. If you made changes to the frontend UI without updating snapshots, this might be the cause. You can download zipped patches containing the updated snapshots alongside a general trace of the tests under the "Artifacts" section in the above page. They're named in the form *_snapshot_diff and *_test_results respectively.

You can read more on how to use these artifacts in the docs.

If the test is flaky, follow the flaky test triage procedure.

@obulat
Copy link
Contributor Author

obulat commented Nov 26, 2024

Closing because the Playwright tests are failing here, replaced with the other Nuxt update PR.

@obulat obulat closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: 🚫 Closed
Development

Successfully merging this pull request may close these issues.

2 participants