Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax and check declarations in Dockerfiles #5183

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Nov 25, 2024

Description

This PR prevents annoying Docker warning annotations on PRs, specifically for the intentional violation of the rule InvalidDefaultArgInFrom in our Dockerfiles.

Testing Instructions

The PR should not have warning annotations from the docker/build-push-action for this specific class of warnings.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: mgmt Related to repo management and automations labels Nov 25, 2024
@dhruvkb dhruvkb requested review from a team as code owners November 25, 2024 16:43
@dhruvkb dhruvkb requested review from krysal and obulat and removed request for a team November 25, 2024 16:43
@openverse-bot openverse-bot added 🧱 stack: api Related to the Django API 🧱 stack: catalog Related to the catalog and Airflow DAGs 🧱 stack: frontend Related to the Nuxt frontend labels Nov 25, 2024
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Thank you!

Copy link

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 6400      ✗ 0   
     data_received..................: 1.5 GB  7.5 MB/s
     data_sent......................: 837 kB  4.2 kB/s
     http_req_blocked...............: avg=29.96µs  min=2.06µs  med=3.92µs   max=12.98ms p(90)=5.49µs   p(95)=5.91µs  
     http_req_connecting............: avg=25.62µs  min=0s      med=0s       max=12.93ms p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=693.28ms min=39.13ms med=600.83ms max=2.63s   p(90)=1.24s    p(95)=1.35s   
       { expected_response:true }...: avg=693.28ms min=39.13ms med=600.83ms max=2.63s   p(90)=1.24s    p(95)=1.35s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 6400
     http_req_receiving.............: avg=172.08µs min=43.64µs med=119µs    max=27.13ms p(90)=188.59µs p(95)=229.64µs
     http_req_sending...............: avg=29.45µs  min=6.24µs  med=19.38µs  max=3.73ms  p(90)=25.53µs  p(95)=27.24µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=693.08ms min=39ms    med=600.69ms max=2.63s   p(90)=1.24s    p(95)=1.35s   
     http_reqs......................: 6400    32.015965/s
     iteration_duration.............: avg=3.7s     min=1.33s   med=3.13s    max=10.51s  p(90)=7.21s    p(95)=7.54s   
     iterations.....................: 1200    6.002993/s
     vus............................: 1       min=1       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@dhruvkb dhruvkb changed the title Add syntax and check declarations above Dockerfiles Add syntax and check declarations in Dockerfiles Nov 25, 2024
@dhruvkb dhruvkb merged commit 507a1ea into main Nov 25, 2024
95 checks passed
@dhruvkb dhruvkb deleted the add_syntax_checks branch November 25, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: api Related to the Django API 🧱 stack: catalog Related to the catalog and Airflow DAGs 🧱 stack: frontend Related to the Nuxt frontend 🧱 stack: mgmt Related to repo management and automations
Projects
Status: 🤝 Merged
Development

Successfully merging this pull request may close these issues.

3 participants