Update the homepage dark color

[obulat]

Fixes

Fixes #4936 by @fcoveram

Description

This PR changes the color of the homepage in dark mode to match the mockups. This also changes the color of the generic error page, you can see the updated version in the changed snapshots.

Testing Instructions

Run the app and go to http://localhost:8443
Change the app theme to dark
Check that the colors are correct, or suggest improvements.
Also check the error page by going to http://localhost:8443/non-existent-page. Note that this page's design will need to be updated, but in this PR only the colors are updated to match the home page.

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
  PRs) or the media properties generator (ov just catalog/generate-docs media-props
  for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[zackkrida]

Barring any design changes from @fcoveram, I think this looks great!

[zackkrida]

@obulat looks like potential flake in an audio test

[obulat]

@obulat looks like potential flake in an audio test

It's #4981. Working on it

[github-actions]

Latest k6 run output¹

$     ✓ status was 200

     checks.........................: 100.00% ✓ 8000      ✗ 0   
     data_received..................: 1.9 GB  8.4 MB/s
     data_sent......................: 1.0 MB  4.7 kB/s
     http_req_blocked...............: avg=18.99µs  min=2.05µs  med=4.09µs   max=9.89ms  p(90)=5.52µs   p(95)=5.99µs  
     http_req_connecting............: avg=13.19µs  min=0s      med=0s       max=9.85ms  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=575.34ms min=76.27ms med=510.22ms max=2.39s   p(90)=1.08s    p(95)=1.19s   
       { expected_response:true }...: avg=575.34ms min=76.27ms med=510.22ms max=2.39s   p(90)=1.08s    p(95)=1.19s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 8000
     http_req_receiving.............: avg=149.87µs min=39.94µs med=116.87µs max=18.05ms p(90)=185.49µs p(95)=226.47µs
     http_req_sending...............: avg=23.45µs  min=6.7µs   med=20.04µs  max=4.99ms  p(90)=25.8µs   p(95)=28.25µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=575.16ms min=76.1ms  med=510.01ms max=2.39s   p(90)=1.07s    p(95)=1.19s   
     http_reqs......................: 8000    36.051829/s
     iteration_duration.............: avg=3.84s    min=1.12s   med=3.18s    max=12.83s  p(90)=8.26s    p(95)=8.85s   
     iterations.....................: 1200    5.407774/s
     vus............................: 4       min=4       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

1. This comment will automatically update with new output each time k6 runs for this PR ↩

[fcoveram]

Most elements look good. But as per this comment, I have pending updating the design file. Once the file is done, do you think it is better to include those changes in this PR or close this one and open a follow-up one?

[obulat]

Most elements look good. But as per this comment, I have pending updating the design file. Once the file is done, do you think it is better to include those changes in this PR or close this one and open a follow-up one?

I think it would be best to draft this PR, and update it once the design changes are ready. Would that be okay? Could you also ping here when the design changes are ready?

[fcoveram]

Sure. No problem!

[github-actions]

Full-stack documentation: https://docs.openverse.org/_preview/4983

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

[obulat]

@fcoveram, I rebased this PR onto the one that fixes the links focus outline colors (Fix link focus rings). That PR fixes the last two problems (Other focus styles).

In this PR, I:

• updated the border color for the content switcher popover to border-overlay

• updated the close button hover state background color

• updated the search bar focus state to move the ring inside

If the link focus rings are okay, could you also approve #4958, @fcoveram ?

[fcoveram]

It looks great 👏 ✨ 🚀