-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update media list admin view to add ES-powered search #4656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent, I think however instead of only recommending query string syntax for advanced search, that specific functionality should be documented. The examples from your PR description may be sufficient!
This is meant to cover this note in the issue and IP:
this field should have helptext reminding the user to also filter by provider in order to disambiguate a specific creator.
But also, I think this type of documentation and examples will make this much easier for moderators to remember.
Side note: /admin/api/image/
still times out with a 504 in production. Are there any plans in the remaining issues for this moderation project to make that page work, or an issue you're aware of to capture that problem?
@zackkrida since the examples and explanation for the search functionality might be a bit too long to fit below the search box, would you recommend I make a separate page for this in the docs and link to it from the search bar help text? That page could document all the different search options from the PR explanation as well as the note about disambiguating a creator by filtering by providers.
Bizarre. There aren't any open issues for that page to be fixed because afaik, those should've been fixed by @AetherUnbound's PR #4349. I'll try to take a look as well. |
@dhruvkb I think some of the value comes from these notes being inline and quick to access for moderators. A page is acceptable but my preference would be text directly on the page. The default font size is so small that a lot of text only takes up a few lines. Additionally, I had an idea: Using a I'll support any approach, however. |
Great idea to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Fixes
Partially addresses #3841 by @stacimc
Description
This PR
Combined with the bulk moderation action added in #4654, the linked issue is fully resolved.
Testing Instructions
3b858852-67df-44e1-8d57-683991d3ec67
creator:"Al S"
creator:Al*
cat
tag.name:cat
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin