Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text-heavy pages should use text-secondary color for text #5119

Closed
obulat opened this issue Oct 31, 2024 · 0 comments · Fixed by #5148
Closed

Text-heavy pages should use text-secondary color for text #5119

obulat opened this issue Oct 31, 2024 · 0 comments · Fixed by #5148
Assignees
@dhruvkb
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Milestone
Dark Mode A - Col...

Comments

@obulat
Copy link
Contributor

obulat commented Oct 31, 2024

Problem

The current value of text color in the dark mode is hard to read due to the contrast being too high.

Description

The text-heavy pages should replace text-default with text-secondary class for text colors.

Alternatives

Additional context
@obulat obulat added ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend labels Oct 31, 2024
@obulat obulat added this to the Dark Mode A - Color Palette milestone Oct 31, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Oct 31, 2024
@dhruvkb dhruvkb self-assigned this Nov 5, 2024
@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Nov 5, 2024
@dhruvkb dhruvkb mentioned this issue Nov 5, 2024
Merged
8 tasks
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Nov 5, 2024
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Nov 25, 2024
@openverse-bot openverse-bot moved this from ✅ Done to 🏗 In Progress in Openverse Backlog Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvkb dhruvkb

Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Status: 🏗 In Progress
Milestone
Dark Mode A - Color Palette
Development

Successfully merging a pull request may close this issue.

Change text color to secondary on content-heavy pages WordPress/openverse
2 participants
@obulat @dhruvkb