Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the skeleton loaders based on latest design changes #4829

Closed
Tracked by #4911
fcoveram opened this issue Aug 28, 2024 · 5 comments · Fixed by #4982
Closed
Tracked by #4911

Update the skeleton loaders based on latest design changes #4829

fcoveram opened this issue Aug 28, 2024 · 5 comments · Fixed by #4982
Assignees
Labels
🖼️ aspect: design Concerns related to design ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend

Comments

@fcoveram
Copy link
Contributor

fcoveram commented Aug 28, 2024

Problem

The current skeleton loaders are outdated due to design changes happening in the Dark Mode project (#3592) and a layout change in the image results.

Related issues

Proposal

The skeletons need to vary per media result, and if possible, per breakpoint when the media component changes to the other variants.

I added mockups that support light and dark modes for the variants I consider necessary in the Design Library.

Regarding the loading state, the color used is bg-fill-secondary, but for the animated gradient effect, I propose testing the following shades.

Mode Base color Secondary color
Light bg-fill-secondary (gray-2) gray-3
Dark bg-fill-secondary (gray-11) gray-10

Storybook links

Mode Search Type
Light All content, image, audio
Dark All content, image, audio

All content results

Skeleton loaders for different breakpoints of all content results

Image results

Skeleton loaders for different breakpoints of all image results

Audio results

Skeleton loaders for different breakpoints of audio results

@fcoveram fcoveram added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 🖼️ aspect: design Concerns related to design labels Aug 28, 2024
@openverse-bot
Copy link
Collaborator

Subscribe to Label Action

cc @WordPress/gutenberg-design, @WordPress/openverse

This issue or pull request has been labeled: "🖼️ aspect: design"

Thus the following users have been cc'd because of the following labels:

  • WordPress/gutenberg-design: 🖼️ aspect: design
  • WordPress/openverse: 🖼️ aspect: design

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Aug 28, 2024
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Aug 28, 2024
@sarayourfriend
Copy link
Collaborator

Note: I wanted to link the storybook component, but up to date, storybook is not available.

Forgive me if you were already aware of this, Francisco, but wanted to make sure you knew that Storybook is temporarily unavailable since the Nuxt 3 migration due to compatibility issues with Nuxt 3. @obulat might have more details about when it will be back.

@obulat
Copy link
Contributor

obulat commented Aug 29, 2024

We've talked about the lack of Storybook elsewhere with Francisco.
Here's the tracking issue for re-adding Storybook: #4728. I tried the nightly build, and it's still failing

@fcoveram
Copy link
Contributor Author

Yes. I knew about the situation and the ticket. Thanks for the reminder. All good 🙂

@zackkrida zackkrida mentioned this issue Sep 11, 2024
8 tasks
@obulat
Copy link
Contributor

obulat commented Sep 20, 2024

I added the Storybook links with the current implementation

@obulat obulat self-assigned this Sep 24, 2024
@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Sep 24, 2024
@obulat obulat added this to the Dark Mode A - Color Palette milestone Sep 24, 2024
@obulat obulat mentioned this issue Sep 24, 2024
8 tasks
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Sep 24, 2024
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖼️ aspect: design Concerns related to design ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants
@fcoveram @obulat @sarayourfriend @openverse-bot and others