Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement over image component #4777

Closed
fcoveram opened this issue Aug 19, 2024 · 2 comments · Fixed by #4831
Closed

Improvement over image component #4777

fcoveram opened this issue Aug 19, 2024 · 2 comments · Fixed by #4831
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend

Comments

@fcoveram
Copy link
Contributor

As per the design introduced in #4563 for an enhanced version of browsing results with sensitive images, the image component requires some changes.

Description

Both versions of the component documented in the Design Library have the following changes:

Image large

  • Blur layer over image has the bg-blur variable
  • In hover and focus, the component shows the text "Sensitive content" inside. Center and bottom aligned

image large variant in Figma with specs

Image small

  • Blur layer over image has the bg-blur variable
  • The text "Sensitive content" replaces the CC license icons
  • In resting state, the label has the text-secondary variable applied
  • In hover and focus states, the label has the text variable applied

image small variant in Figma with specs

The alias mentioned above go as (copied from this comment):

Colors

  • white-88: #FFFFFF at 88%
  • black-72: #000000 at 72%

Alias

# Light theme

:root {
	bg-blur: var(white-88);
}

# Dark theme

:root {
	bg-blur: var(black-72);
}

Additional context

The tokens applied are according to #3592 project

@fcoveram fcoveram added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🧱 stack: frontend Related to the Nuxt frontend labels Aug 19, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Aug 19, 2024
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Aug 19, 2024
@dhruvkb dhruvkb self-assigned this Aug 26, 2024
@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Aug 26, 2024
@dhruvkb
Copy link
Member

dhruvkb commented Aug 28, 2024

In the process of implementing this I have observed that the text "Sensitive content" splits into two lines for tall images. For example, see the highlighted image in this screenshot.

image

@fcoveram does this look okay? Would you like to suggest some changes?

@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Aug 28, 2024
@fcoveram
Copy link
Contributor Author

That looks good to me

@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants