Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related media heading sizes different in audio/image pages #3863

Open
obulat opened this issue Mar 2, 2024 · 3 comments
Open

Related media heading sizes different in audio/image pages #3863

obulat opened this issue Mar 2, 2024 · 3 comments
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend

Comments

@obulat
Copy link
Contributor

obulat commented Mar 2, 2024

Problem

The Related images uses a Heading 5 for screens above md and the Related audio always uses a Heading 6. These both should probably be Heading 5 above md, @fcoveram ?

image

Additional context

First reported by @zackkrida : #3831 (comment)

This issue is blocked because it needs input from @fcoveram

Changes necessary

class="heading-6 mb-6"
:class="results.type === 'image' ? 'md:heading-5' : 'lg:heading-6'"

Should be changed to

class="heading-6 mb-6 md:heading-5"

The visual regression test snapshots will probably need to be updated. Here's the documentation on the update procedure: https://docs.openverse.org/frontend/reference/testing_guidelines.html#debugging

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software ⛔ status: blocked Blocked & therefore, not ready for work 🧱 stack: frontend Related to the Nuxt frontend labels Mar 2, 2024
@openverse-bot openverse-bot moved this to ⛔ Blocked in Openverse Backlog Mar 2, 2024
@fcoveram
Copy link
Contributor

fcoveram commented Mar 6, 2024

Yes, you are right. Heading 5 for screens above md in both pages.

@obulat obulat added good first issue New-contributor friendly help wanted Open to participation from the community and removed ⛔ status: blocked Blocked & therefore, not ready for work labels Jul 31, 2024
@openverse-bot openverse-bot moved this from ⛔ Blocked to 📋 Backlog in Openverse Backlog Jul 31, 2024
@Mang0codes
Copy link

Hi! I would like to work on this.

@obulat
Copy link
Contributor Author

obulat commented Oct 28, 2024

Hi @Mang0codes ! Please go ahead, I'm going to assign the issue to you.

@obulat obulat assigned obulat and Mang0codes and unassigned obulat Oct 28, 2024
@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: 📅 To Do
Development

No branches or pull requests

3 participants