From 153907f4ee17ad7e0b79ba62df081a0b7835e001 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Fri, 8 Nov 2024 12:33:03 +0100 Subject: [PATCH] GH Actions: use explicit PHPStan major This Monday, [PHPStan 2.0 will be released](https://phpc.social/@OndrejMirtes/113441109253809720). I've done some preliminary scans with PHPStan 2.0-dev to check if this would have an impact on this codebase and as things are, this would mean the build would start to fail. For now, I'm proposing to make a small change in the GH Actions workflow to explicitly use PHPStan 1.x. This buys us some time to evaluate PHPStan 2.0 properly and to make any changes needed to make the codebase compatible with PHPStan 2.x when we're ready for it. --- .github/workflows/basic-qa.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/basic-qa.yml b/.github/workflows/basic-qa.yml index 8c3975499..4292aa58d 100644 --- a/.github/workflows/basic-qa.yml +++ b/.github/workflows/basic-qa.yml @@ -207,7 +207,7 @@ jobs: with: php-version: 'latest' coverage: none - tools: phpstan + tools: phpstan:1.x # Install dependencies and handle caching in one go. # Dependencies need to be installed to make sure the PHPCS and PHPUnit classes are recognized.