Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 lighthouse action #30

Merged
merged 10 commits into from
Apr 26, 2024
Merged

5 lighthouse action #30

merged 10 commits into from
Apr 26, 2024

Conversation

RossellaFer
Copy link
Contributor

@RossellaFer RossellaFer commented Apr 25, 2024

Resolves #5 Github action for Lighthouse

What changed 🧐

  • setup the action Lighthouse CI
    The action will test the homepage 3 times and generate a report with the scores, similar to this this one)
  • changed the ESLint configuration to work with the lighthouserc.cjs file

How did you test it? 🧪

Manual testing by running the commands

npm install && npm install -g @lhci/[email protected]
npm run build
lhci autorun

lighthouserc.cjs Outdated Show resolved Hide resolved
lighthouserc.cjs Outdated Show resolved Hide resolved
@ann-kilzer
Copy link
Collaborator

This looks awesome. I don't know if there is an easy way to get the report in front of the developers, but perhaps that could be a follow up task. https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1714039530164-69286.report.html

I made a few suggestions about tweaking the metrics, because I think aiming for 80-90% scores across the board will be a healthier target.

🤩 thank you

Copy link
Collaborator

@ann-kilzer ann-kilzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ann-kilzer ann-kilzer merged commit 96f7f03 into main Apr 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Action for Lighthouse
2 participants