Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor show endpoint #10

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

leoncalermo
Copy link

Summary

  • Created Contributor show endpoint with tests

Screenshots

[Change!] Show the screenshots of the views you modified.

Trello Card

Copy link
Contributor

@marcegl91 marcegl91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🎉

@@ -20,7 +20,7 @@
"description": "when calling the endpoint without any params",
"content": {
"application/json": {
"example": "{\"page\":[{\"id\":11,\"name\":\"Flerovium\",\"created_at\":\"2020-04-01T14:04:59.438Z\",\"updated_at\":\"2020-04-01T14:04:59.438Z\"},{\"id\":12,\"name\":\"Lutetium\",\"created_at\":\"2020-04-01T14:04:59.440Z\",\"updated_at\":\"2020-04-01T14:04:59.440Z\"},{\"id\":13,\"name\":\"Technetium\",\"created_at\":\"2020-04-01T14:04:59.441Z\",\"updated_at\":\"2020-04-01T14:04:59.441Z\"},{\"id\":14,\"name\":\"Einsteinium\",\"created_at\":\"2020-04-01T14:04:59.443Z\",\"updated_at\":\"2020-04-01T14:04:59.443Z\"},{\"id\":15,\"name\":\"Yttrium\",\"created_at\":\"2020-04-01T14:04:59.444Z\",\"updated_at\":\"2020-04-01T14:04:59.444Z\"}],\"count\":5,\"total_pages\":1,\"total_count\":5,\"current_page\":1,\"previous_page\":null,\"next_page\":null}"
"example": "{\"page\":[{\"id\":11,\"name\":\"Dubnium\",\"created_at\":\"2020-04-14T20:34:03.114Z\",\"updated_at\":\"2020-04-14T20:34:03.114Z\"},{\"id\":12,\"name\":\"Actinium\",\"created_at\":\"2020-04-14T20:34:03.117Z\",\"updated_at\":\"2020-04-14T20:34:03.117Z\"},{\"id\":13,\"name\":\"Plutonium\",\"created_at\":\"2020-04-14T20:34:03.119Z\",\"updated_at\":\"2020-04-14T20:34:03.119Z\"},{\"id\":14,\"name\":\"Gold\",\"created_at\":\"2020-04-14T20:34:03.121Z\",\"updated_at\":\"2020-04-14T20:34:03.121Z\"},{\"id\":15,\"name\":\"Carbon\",\"created_at\":\"2020-04-14T20:34:03.123Z\",\"updated_at\":\"2020-04-14T20:34:03.123Z\"}],\"count\":5,\"total_pages\":1,\"total_count\":5,\"current_page\":1,\"previous_page\":null,\"next_page\":null}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why I don't like using Faker in factories :(, but it can't be helped.

"next_page": { "type": "integer, null" },
"previous_page": { "type": "string, null" }
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants