Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom abbreviations (via config file) #396

Open
DrDragonKiller opened this issue Sep 17, 2016 · 1 comment
Open

Custom abbreviations (via config file) #396

DrDragonKiller opened this issue Sep 17, 2016 · 1 comment
Milestone

Comments

@DrDragonKiller
Copy link

I used the following pattern for renaming:
"%type_1% %type_2%%iv_rating%%move_type_1% %move_type_2%"
would lead to:
Wa Fg96gd gd
No __56gh gh
Wa __84WA WA

Question(s) and suggestions:

  1. Why is the WA in capital letters?! I first thought because both moves are of the same type but in the first example both are lower case?

  2. Is there a way how we can change the abbreviation? Because I'm German and I would like to see Bo (Boden) instead of gd for ground. But I think a settings file for custom shortcuts would be best!

  3. Would it be possible to use some if's for renaming:
    for example if the pokemon is only of one type use following pattern:
    "%type_1% %iv_rating%%move_type_1% %move_type_2%" ("No 56gh gh" instead of "No __56gh gh")
    or for example if both attacks from the same type or if both of them aplly and so on...

@Wolfsblvt Wolfsblvt added this to the v0.1.3 milestone Sep 17, 2016
@Wolfsblvt
Copy link
Owner

  1. Is answered easily. Capital letters are used to quickly show you that STAB (=Same Type Attack Bonus) applies to that move (:
  2. German fellow too here :P Difficult. As far as I know Moves can't be translated with the current API, but custom abbreveations via settings would be possible I guess. Will keep the issue open for that.
  3. Difficult. At first I thought about using empty string if Second Type is not available, but the problem there is that we have limited character for names (12 exactly), so it would help to keep every name with the exact same length. That's why 5% IV will be displayed as "05" too.
    But if we add custom abbreveations you can just use empty string to abbriviate "None".

@Wolfsblvt Wolfsblvt changed the title Advanced renaming (3 Suggestions) Custom abbreviations (via config file) Sep 21, 2016
@Wolfsblvt Wolfsblvt modified the milestones: v0.1.4, v0.1.3, v0.1.5 Sep 30, 2016
@Wolfsblvt Wolfsblvt modified the milestones: v0.2.0, v0.1.5 Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants