Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: unlocking from an armorstand gives itemframe msg #272

Open
InnerAbyssal opened this issue Jun 19, 2023 · 1 comment
Open

[Bug]: unlocking from an armorstand gives itemframe msg #272

InnerAbyssal opened this issue Jun 19, 2023 · 1 comment
Labels
bug Something isn't working BUG-1: Reproduced Scenario's Successfully Reproduced BUG-3: MINOR For Minor Bugs - Language Files missing TS etc. Build: Devel Issues in Development Build: Release Issues in Production good first issue Good for newcomers help wanted Extra attention is needed To Be Fixed: Later Stage Items that we want to fix but are not currently possible to be fixed.
Milestone
ASE: Future Versi...

Comments

@InnerAbyssal
Copy link

Expected behavior

When pressing F to unlock from an armorstand the hotbar text would say "Armorstand target unlocked"

Observed/Actual behavior

When pressing F to unlock from an armorstand the hotbar text would say "Itemframe target unlocked"

Steps/models to reproduce

place an armorstand
grab the appropriate tool for asedit that was set in your config
(in my case flint)

lock to an armorstand by looking at it & pressing F
2023-06-19_19 25 21
Turn away from the armorstand.

Press F again to unlock
2023-06-19_19 25 31

Plugin list

[17:26:54 INFO]: - AdvancedMobs, AdvancedRegionMarket, ArmorStandEditor, AuctionHouse, AuctionHouse, BetterShulkerBoxes, BlueMap, BlueMapPlayerControl, BroadcastPlus, ChatItem
[17:26:54 INFO]: ChatReaction, ChestSort, Citizens, CommandTool, CoreProtect, CoreProtectTNT, CraftingStore, CrazyEnvoys, *CustomHeads, DailyBonus
[17:26:54 INFO]: DeathMessages, DeluxeMenus, Denizen, DiscordSRV, DontExplodeSpawners, DropHeads, dtlTraders, *EasyClearChat, eGlow, Essentials
[17:26:54 INFO]: EssentialsChat, EssentialsSpawn, ExcellentCrates, ExecutableItems, FastAsyncWorldEdit, floodgate, Floristics, Geyser-Spigot, GPFlags, GriefPrevention
[17:26:54 INFO]: GSit, HeadsPlus, ImageMaps, InsaneAnnouncer, InventoryRollbackPlus, IronicGifts, ItemSlotMachine, JumpPads, LibsDisguises, LootChest
[17:26:54 INFO]: LuckPerms, MiniMOTD, Multiverse-Core, MyCommand, NexEngine, OpenInv, PinataParty, PlaceholderAPI, PlayerWarps, PlotSquared
[17:26:54 INFO]: PlotSquared, ProtocolLib, PvPManager, PwnFilter, QuickShop, RandomTeleport, RewardsLite, SCore, ServerSigns, SilkTouchAmethyst
[17:26:54 INFO]: SleepFixer, SpawnerMeta, StackResize, TAB, TreeFeller, UltraCosmetics, Vanish, Vault, ViaBackwards, ViaVersion
[17:26:54 INFO]: Votifier, WorldEdit, WorldGuard, WorldGuardExtraFlags

Plugin Version

1.20.0-43.beta

Server Version

1.20.0

Other

No response
@InnerAbyssal InnerAbyssal added bug Something isn't working BUG-0: Pending Investigation BUGS/ISSUES Pending Investigation labels Jun 19, 2023
@Wolfieheart Wolfieheart mentioned this issue Jun 19, 2023
Merged
14 tasks
@Wolfieheart Wolfieheart added help wanted Extra attention is needed good first issue Good for newcomers BUG-1: Reproduced Scenario's Successfully Reproduced Build: Devel Issues in Development Build: Release Issues in Production BUG-3: MINOR For Minor Bugs - Language Files missing TS etc. To Be Fixed: Later Stage Items that we want to fix but are not currently possible to be fixed. and removed BUG-0: Pending Investigation BUGS/ISSUES Pending Investigation labels Jun 20, 2023
@Wolfieheart Wolfieheart pinned this issue Jul 3, 2023
Wolfieheart added a commit that referenced this issue Sep 10, 2023
@Wolfieheart
[CORE] Fix for Messages not being sent properly in ASE. Bug from #315
bf80192 
Plus Potential Fix for #272
@Wolfieheart
Copy link
Owner

Hey @InnerAbyssal Give the fix a try:

https://github.com/Wolfieheart/ArmorStandEditor/actions/runs/6136455379 - Download the Artifact from there and Unzip the JAR file there within. Please do not use this in production yet, as this is not meant for that.

If you are going to test, please just reply to this with any bugs you find as well as a clear reproduction scenario :)

Wolfieheart added a commit that referenced this issue Oct 12, 2023
@Wolfieheart
[CORE] ArmorStandEditor 1.20-44: Fixes and New UI! (#311)
c1fce65 
* [CORE] Version Bump: 1.20-44

* [CORE] Fix for #309. Add Check for ArmorStand Vulnerability and prevent destruction in Creative Mode when its Invulnerable

* [CORE] Upgrade Codebase to 17

* [CORE] Bump Base API Version to 1.17

* [CORE] Autoformatting and Order Imports

* [CORE] Per World Support for ArmorStandEditor

* [CORE] Better Implementation for Per World Support for ArmorStandEditor. More in line with what is expected!

* [CORE] Better Implementation for Per World Support for ArmorStandEditor. More in line with what is expected!

* [CORE] Version Bump: 1.20-44

* [CORE] Fix for #309. Add Check for ArmorStand Vulnerability and prevent destruction in Creative Mode when its Invulnerable

* [CORE] Upgrade Codebase to 17

* [CORE] Bump Base API Version to 1.17

* [CORE] Autoformatting and Order Imports

* [CORE] Per World Support for ArmorStandEditor

* [CORE] Better Implementation for Per World Support for ArmorStandEditor. More in line with what is expected!

* [CORE] Better Implementation for Per World Support for ArmorStandEditor. More in line with what is expected!

* [CORE] Config Support for Per World ArmorStandEditor.

* [CI-SKIP] Something to use for later if we ever move to Paper.

* [CORE] Fix for Messages not being sent properly in ASE. Bug from #315

Plus Potential Fix for #272

* [CORE] Bump ASE to 1.20.2-44

* [CORE] New UI Design #DreiFxn

* [CORE] Upgrade Fix: Fix ArmorStandVisibility Not working Properly

* [CORE] Bump Lands to 6.35.0 - Closes #310 and #328

* [CORE] Bump Towny to 0.99.5.20 - Closes #326 and #332

* [CORE] Bump Lombok to 1.18.30

* [CORE] Bump MavenShade to 3.5.1

* [CORE] Fixes found when Debugging 1.20.2-44:

- Add in No Perm Message if a user cant run a certain toggle
- Fix for the PlayerHead Menu Option
- Add all new strings for NoPermOption to the Language Files
- Fix Toggles

* [CORE] Refactor PlotSquared Protection

* [CORE] Refactor PlotSquared Protection (Part 2 - Comments + Readability)

* [CORE] Stats Command #334 (Part 1) - Add the Java Logic, No Language Support or Perm Support YET!

* [CI-SKIP] Tabbing was outta sync. Fixed it

* [CORE] Stats (Part 2 of 3) - Add missing Language Strings to test realm

* [CORE] Temporary fix for ArmorStand Names being weird and wacky when broken and placed back down.

* [CORE] Temporary fix for ArmorStand Names being weird and wacky when broken and placed back down.

* [CORE] Temporary fix for ArmorStand Names being weird and wacky when broken and placed back down.

* [CORE] Introduce Glowing Toggle:

- Requires `asedit.togglearmorstandglow` to be true
- Will only Glow `white`, otherwise will need to implement a whole scoreboard system just for all the colors. Something I dont wanna impose on people.
- Menu Option: `Glow Ink Sac`, Placement might vary
- Add to Stats tracker
- Add Language Strings for it.

* [CORE] Code Review Remarks - Apparently `CodeFactor` didnt like how I was doing the Stats calculations

* [CORE] Add Missing Modes to TabCompletion

* [CORE/LANG] Stats (part 3) - Add translation things

* [CORE] Change Version for Beta Deployment

* [CORE] Fix PlotSquared Protection Error on PlotAPI

* [CORE] One Final P2 Change and Bump to Final

* [CORE] Fix Dependencies

* [CORE] Fix Bug and Dependencies

* [CORE] Bump RU_RU.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working BUG-1: Reproduced Scenario's Successfully Reproduced BUG-3: MINOR For Minor Bugs - Language Files missing TS etc. Build: Devel Issues in Development Build: Release Issues in Production good first issue Good for newcomers help wanted Extra attention is needed To Be Fixed: Later Stage Items that we want to fix but are not currently possible to be fixed.
Projects
None yet
Milestone
ASE: Future Version Support
Development

No branches or pull requests
2 participants
@Wolfieheart @InnerAbyssal