Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the bot respond to all links instead of trying to avoid spamming? #14

Open
MartijnHols opened this issue Jan 17, 2018 · 0 comments

Comments

@MartijnHols
Copy link
Member

Readme says this:

It stopped responding to my links!
To avoid spamming when a log gets passed around a lot for analysis the bot ignores repeated links for the same report. (let us know if you think this should be more) This also includes links that were never responded to, such as if they have were ignored due to being presumed used for analysis. This may happen if the report link had an ability selected, was on an other view than the default, had a time or phase selection active or had a pin. All these factors cause the report URL to be assumed used for a reason other than a request for analysis, and will be ignored to avoid the bot being annoying.

The most common use-case I see is setting up the bot in a separate channel for log analysis making some of these checks annoying rather than helpful, Should we disable some of them?

My thoughts:

  • the bot ignores repeated links for the same report: I think we should keep this enabled but ensure it only restricts per channel instead of server-wide. Reason is that some users send another link with a different fight selected to switch fights instead of using the interface. While this doesn't really matter for us, I think supporting this may lead to spammed log analysis channels. Secondly it happens occasionally that someone ask for log analysis in a general channel and then links it in the log analysis channel, that shouldn't be ignored.
  • if the report link had an ability selected: I think it makes sense to continue doing this, extremely rare to link something like this with the purpose of the bot responding
  • on an other view than the default: I think we should disable this, users often link rankings or other pages because that was simply the last page they visited.
  • had a time or phase selection active or had a pin: probably keep this enabled since I haven't seen a false positive yet and it makes sense
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant