Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid access evaluation in download.php #12

Open
mudrd8mz opened this issue Aug 6, 2021 · 0 comments
Open

Invalid access evaluation in download.php #12

mudrd8mz opened this issue Aug 6, 2021 · 0 comments

Comments

@mudrd8mz
Copy link

mudrd8mz commented Aug 6, 2021

This looks suspicious: https://github.com/WisdmLabs/moodle-local_edwiserreports/blob/106d7243bf1c5140032e775d29e350b4178a5a3f/download.php#L66-L67

Did not you mean it like

if (!is_siteadmin() || !can_view_block(...)) {

}

instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant