Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VS2019 in Import-VisualStudioEnvironment #12

Open
tats-u opened this issue Aug 29, 2019 · 3 comments · May be fixed by #13
Open

Support VS2019 in Import-VisualStudioEnvironment #12

tats-u opened this issue Aug 29, 2019 · 3 comments · May be fixed by #13

Comments

@tats-u
Copy link

tats-u commented Aug 29, 2019

Could you support VS2019 in Import-VisualStudioEnvironment?
I can't touch the already-signed code.

PS tatsu@TATSU-NB-3RD:~$ Import-VisualStudioEnvironment
The system cannot find the path specified.
ERROR: Error executing CMD.EXE: 1
PS tatsu@TATSU-NB-3RD:~$ Import-VisualStudioEnvironment 2019
Import-VisualStudioEnvironment : Cannot validate argument on parameter 'VSVersion'. The argume
nt "2019" does not belong to the set "Latest,2013,2015,2017" specified by the ValidateSet attr
ibute. Supply an argument that is in the set and then try the command again.
At line:1 char:32
+ Import-VisualStudioEnvironment 2019
+                                ~~~~
    + CategoryInfo          : InvalidData: (:) [Import-VisualStudioEnvironment], ParameterBin 
   dingValidationException
    + FullyQualifiedErrorId : ParameterArgumentValidationError,Import-VisualStudioEnvironment 
 
PS tatsu@TATSU-NB-3RD:~$ Import-VisualStudioEnvironment Latest
The system cannot find the path specified.
ERROR: Error executing CMD.EXE: 1
@JohnWintellect
Copy link
Member

Unfortunately, I'm not doing active development much anymore these days. If you pull down the code for this repo you can make the fix in there, push me the patch, and I can do the signing.

@tats-u
Copy link
Author

tats-u commented Sep 5, 2019

I got it. I suppose these changes are needed:

  1. Add "2019" in
    [ValidateSet("Latest", "2013", "2015", "2017")]
  2. Add "2019" { "16.0" } in
    "2013" { "12.0" }
    "2015" { "14.0" }
    "2017" { "15.0" }

Similar changes may be required in, e.g.,

@tats-u
Copy link
Author

tats-u commented Sep 11, 2019

Should I create a PR or formal diff file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants