Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show option popover when clicking on hackernews links within comments/post content #4

Open
2 tasks
WilsonOh opened this issue Nov 8, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@WilsonOh
Copy link
Owner

WilsonOh commented Nov 8, 2023

Background

Currently, hackernews links within comments or posts will open in the original hackernews website (naturally). This might disrupt the user experience of hackernews-next if the user wants to continue browsing other hackernews items on the same website.

Tasks

  • using the replace/transform option in react-html-parser, replace all <a> tags where the URI starts with news.ycombinator.com/item with a custom link component.
  • set up the custom link component such that clicking it will trigger a popover, presenting the user with 2 choices - go to the original link or view the item in hackernews-next

Acceptance Criteria

  • Upon clicking a link matching news.ycombinator.com/item in comments or posts, a popover will be triggered, allowing the user to choose between going to news.ycombinator.com/item or hn.oyxw.xyz/item
@WilsonOh WilsonOh added the enhancement New feature or request label Nov 8, 2023
@WilsonOh WilsonOh added this to the v1.0.0 milestone Nov 8, 2023
@WilsonOh WilsonOh self-assigned this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant