Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run app through quality gate #162

Open
o-fish-wildaid opened this issue Jul 28, 2020 · 2 comments
Open

Run app through quality gate #162

o-fish-wildaid opened this issue Jul 28, 2020 · 2 comments
Labels
days: 5+ Estimated to take 5 or more days to implement enhancement New feature or request hacktoberfest

Comments

@o-fish-wildaid
Copy link
Collaborator

Run app through a static code analyzer to find issues.
@o-fish-wildaid o-fish-wildaid added the enhancement New feature or request label Jul 28, 2020
@Sheeri Sheeri added this to the Demo v23 8/18 milestone Aug 3, 2020
@kojiba
Copy link
Contributor

kojiba commented Aug 5, 2020

Possible steps and tools list:

For CI/CD loop add needed stages:

  1. Run build check
  2. Run all test check (unit and screenshot tests)
  3. Run xcov+danger or something similar to report the current test coverage and warnings/errors
  4. Need to integrate current swiftlint with danger to get pretty report
  5. Post PR report inside the PR as a comment

@akaktus akaktus self-assigned this Aug 13, 2020
@Sheeri Sheeri modified the milestones: Demo v23 8/18, Demo v24 8/25 Aug 19, 2020
@Sheeri Sheeri modified the milestones: Demo v26 9/8, Demo v27 9/15 Sep 8, 2020
@am-MongoDB am-MongoDB added the days: 5+ Estimated to take 5 or more days to implement label Sep 14, 2020
@Sheeri Sheeri modified the milestones: Demo v27 9/15, Demo v28 9/22 Sep 15, 2020
@Sheeri Sheeri modified the milestones: Demo v28 9/22, Demo v29 9/29, v31 10/13, v33 10/27 Sep 23, 2020
@akaktus akaktus removed their assignment Sep 24, 2020
@Sheeri Sheeri removed this from the v33 10/27 milestone Oct 1, 2020
@Sheeri
Copy link
Collaborator

Sheeri commented Oct 1, 2020

The first step is running the app through the quality gate; this issue doesn't have to handle fixing everything that comes up, though one or two obvious issues should be fixed for this to be a high quality contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
days: 5+ Estimated to take 5 or more days to implement enhancement New feature or request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Sheeri @kojiba @am-MongoDB @akaktus @o-fish-wildaid