Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ryandesign
Copy link

@ryandesign ryandesign commented Nov 26, 2023

This PR contains commits that fix some warnings reported by clang 17:

I have only tested this on macOS 12. Please test on other supported platforms before merging to verify I haven't inadvertently broken something.

@ryandesign
Copy link
Author

More code changes are needed to eliminate other warnings. I didn't want to put too many things into one PR since that can be hard to review, but the next changes will build on these. If you can merge the open PRs, maybe I can find time to work on more fixes. Or if you have objections to the proposed changes let me know.

@Wikinaut
Copy link
Owner

Wikinaut commented Dec 1, 2023

@ryandesign Thanks for your plenty reports. I will try to catch up as my next project.

I suppose that you only submitted and submit pull reports which fully works [at least] for you, thanks in advance.

PS
You might have noticed, that the project goes back to the late 80ies. I worked hard (behind the curtains and in contact with Golda and Udi) to get the sources free - which is luckily the case since a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants