Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OS, compiler version, date, and time from version string #24

Open
ryandesign opened this issue Nov 26, 2023 · 0 comments · May be fixed by #25
Open

Remove OS, compiler version, date, and time from version string #24

ryandesign opened this issue Nov 26, 2023 · 0 comments · May be fixed by #25

Comments

@ryandesign
Copy link

agrep -V prints this on macOS:

AGREP 3.41.5/TG for NATIVE LINUX compiled with GCC Clang 17.0.5 (Nov 25 2023 18:24:29). Manber/Wu/Gries et al.

See:

agrep/version.h

Line 73 in b7d180f

#define AGREP_VERSION_STRING "AGREP "AGREP_VERSION" for "AGREP_OS" compiled with GCC "__VERSION__" ("__DATE__" "__TIME__"). Manber/Wu/Gries et al."

Please remove the OS name from this line since it is obviously fictitious on operating systems like macOS that you didn't explicitly consider and is not necessary since everybody already knows what operating system they're using.

Please remove "GCC" and the compiler version since it is confusing when the compiler that was used is not GCC and nobody cares what compiler or version a program was compiled with.

Please remove the compilation date and time since that renders your build non-reproducible and nobody cares when a program was compiled.
ryandesign added a commit to ryandesign/agrep that referenced this issue Nov 26, 2023
@ryandesign
Don't print OS, compiler, or compilation date/time
22281ee 
Fixes Wikinaut#24
@ryandesign ryandesign linked a pull request Nov 26, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't print OS, compiler, or compilation date/time ryandesign/agrep
1 participant
@ryandesign