From afea008f4c5c53cbf17970aa56ca7c6a4fc38e51 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Kowalczyk?= Date: Wed, 26 Aug 2020 13:18:11 +0200 Subject: [PATCH 1/2] IW-4246 | Removing smart banner --- app/services/smart-banner.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/services/smart-banner.js b/app/services/smart-banner.js index 43c0b2a8f1a..a64c1b3a2a7 100644 --- a/app/services/smart-banner.js +++ b/app/services/smart-banner.js @@ -28,7 +28,7 @@ export default Service.extend({ dbName: readOnly('wikiVariables.dbName'), smartBannerAdConfiguration: readOnly('wikiVariables.smartBannerAdConfiguration'), isUserLangEn: equal('currentUser.language', 'en'), - shouldShowFandomAppSmartBanner: and('isUserLangEn', 'wikiVariables.enableFandomAppSmartBanner'), + shouldShowFandomAppSmartBanner: false, //and('isUserLangEn', 'wikiVariables.enableFandomAppSmartBanner'), isFandomAppSmartBannerVisible: computed( 'shouldShowFandomAppSmartBanner', 'smartBannerVisible', From 161df679397b0d5e78bbeef827fe214485f71fb5 Mon Sep 17 00:00:00 2001 From: Tomek Kasperek Date: Wed, 26 Aug 2020 14:49:53 +0200 Subject: [PATCH 2/2] Move comment above the line --- app/services/smart-banner.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/services/smart-banner.js b/app/services/smart-banner.js index a64c1b3a2a7..5de36cd011c 100644 --- a/app/services/smart-banner.js +++ b/app/services/smart-banner.js @@ -28,7 +28,8 @@ export default Service.extend({ dbName: readOnly('wikiVariables.dbName'), smartBannerAdConfiguration: readOnly('wikiVariables.smartBannerAdConfiguration'), isUserLangEn: equal('currentUser.language', 'en'), - shouldShowFandomAppSmartBanner: false, //and('isUserLangEn', 'wikiVariables.enableFandomAppSmartBanner'), + // shouldShowFandomAppSmartBanner: and('isUserLangEn', 'wikiVariables.enableFandomAppSmartBanner'), + shouldShowFandomAppSmartBanner: false, isFandomAppSmartBannerVisible: computed( 'shouldShowFandomAppSmartBanner', 'smartBannerVisible',