You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.
Members of the House and Senate classes are too private. I suggest making them public so other classes can access and change them if needed. Furthermore, their deconstructor method should also be made public.
As a bonus improvement, since both classes above break the Singleton pattern by extending their parent Congress, the Congress class should no longer be a Singleton.
Willing to fork project, but don't have the time to commit. Will still contribute to it by placing votes.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Members of the House and Senate classes are too private. I suggest making them public so other classes can access and change them if needed. Furthermore, their deconstructor method should also be made public.
As a bonus improvement, since both classes above break the Singleton pattern by extending their parent Congress, the Congress class should no longer be a Singleton.
Willing to fork project, but don't have the time to commit. Will still contribute to it by placing votes.
The text was updated successfully, but these errors were encountered: