Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec document tweaks and fixes from @rossberg #98

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

sbc100
Copy link
Member

@sbc100 sbc100 commented Nov 6, 2024

  • Removed unnecessary/mismatching lookup of table/memory type in execution prose
  • Added missing result type lookup in formal rule for table.size and memory.size
  • Fixed computation of -1 result value for table.grow and table.size to work for i64
  • Some fixes around specification of text format for inline elements/data shorthand
  • Fixed matching rules for tabletype/memtype to enforce same address type

Split out from WebAssembly/spec#1839

- Removed unnecessary/mismatching lookup of table/memory type in execution prose
- Added missing result type lookup in formal rule for table.size and memory.size
- Fixed computation of -1 result value for table.grow and table.size to work for i64
- Some fixes around specification of text format for inline elements/data shorthand
- Fixed matching rules for tabletype/memtype to enforce same address type

Split out from #1839
@sbc100 sbc100 requested a review from rossberg November 6, 2024 22:01
@sbc100 sbc100 changed the title Memory64 spec tweaks and fixes from @rossberg Spec document tweaks and fixes from @rossberg Nov 6, 2024
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp

@sbc100 sbc100 merged commit ace0947 into main Nov 6, 2024
8 checks passed
@sbc100 sbc100 deleted the document_updates branch November 6, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants