Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with swift 5.4? #68

Open
bourvill opened this issue Apr 28, 2021 · 7 comments
Open

Error with swift 5.4? #68

bourvill opened this issue Apr 28, 2021 · 7 comments

Comments

@bourvill
Copy link

Hello,

Before 5.4 it's ok.
Now I try to use Gitbuddy with swift 5.4 I got trace trap

[1] 29091 trace trap

I try to rebuild from source and run this

swift run --package-path /Volumes/perso/GitBuddy/ GitBuddy changelog -s 1.1.1

And got

Swift/ContiguousArrayBuffer.swift:580: Fatal error: Index out of range
[1]    29091 trace trap  swift run --package-path /Volumes/perso/GitBuddy/ GitBuddy changelog -s 1.1.1
@aboedo
Copy link

aboedo commented Jan 4, 2022

Seems like this is still valid with Swift 5.5.2. Any updates?

@AvdLee
Copy link
Contributor

AvdLee commented Jan 24, 2022

I'm about to create a new release, could you try with that one? I tried it locally and it works here

@aboedo
Copy link

aboedo commented Jan 25, 2022

same result... but it seems like there might be something off with the release?
running

> gitbuddy --version

outputs

3.1.1

even after upgrading. Always through mint. I tried on a clean mac and one that had 3.1.1 installed before.

image

Thoughts? I haven't tried manual install this time around

@aboedo
Copy link

aboedo commented Jan 25, 2022

yeah the tagged 4.0.0 version has 3.1.1 in the code https://github.com/WeTransfer/GitBuddy/blob/4.0.0/Sources/GitBuddyCore/Commands/GitBuddy.swift, can't tell if that's the only thing that's outdated in the tag, though

@aboedo
Copy link

aboedo commented Jan 25, 2022

feels like the tag might have been made in the wrong commit? 4.0.0...master

@AvdLee
Copy link
Contributor

AvdLee commented Jan 26, 2022

Ah, interesting! I'm pretty sure the release is made from the right commit, but I'll make sure to update the version number accordingly.

@AvdLee
Copy link
Contributor

AvdLee commented Jan 26, 2022

@aboedo I just did another try locally and it just works. Can you try running:

$ gitbuddy changelog -s 1.1.1 --verbose

Note: --verbose won't work if you use --package-path since the verbose flag is taken away by swift. If building from source, you want enable verbosity hardcoded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants