Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor scripts pathing to run from repo base path #12

Open
MikeLippincott opened this issue Aug 9, 2024 · 0 comments
Open

Refactor scripts pathing to run from repo base path #12

MikeLippincott opened this issue Aug 9, 2024 · 0 comments

Comments

@MikeLippincott
Copy link
Member

          Seeing the number of `cd` commands made me concerned that this might be challenging to maintain (there are also `cd`'s in the scripts). Would it make sense to remove the nested `cd`'s in the script files sourced here to make directory control "single-sourced"? Generally, where you can, I recommend running all scripts as though they were run from the same location (instead of from within the nested directories), referencing full paths from the context of the project throughout. I bring this up out of care for the development overhead which multiple directory location / relocations can cause.

Originally posted by @d33bs in #8 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant