Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix damage formula against structures/features #3361

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

KJeff01
Copy link
Member

@KJeff01 KJeff01 commented Aug 31, 2023

Since level defaulted to 1 it meant structures/features here would set actualDamage to 94% as the base damage value.

@KJeff01 KJeff01 added this to the 4.4.0-beta1 milestone Aug 31, 2023
@KJeff01 KJeff01 changed the title Fix damage formula against structures Fix damage formula against structures/features Aug 31, 2023
@KJeff01 KJeff01 removed this from the 4.4.0-beta1 milestone Aug 31, 2023
@KJeff01
Copy link
Member Author

KJeff01 commented Aug 31, 2023

Alright boys, we gotta do a whole rebalance for structures both in campaign and multiplayer for this at a minimum. lol.

@past-due past-due marked this pull request as draft August 31, 2023 18:47
@past-due
Copy link
Member

Alright boys, we gotta do a whole rebalance for structures both in campaign and multiplayer for this at a minimum. lol.

I concur.

While it would be super helpful for actually calculating balance values and comparisons to fix this in the core, by itself this change will just make structures slightly weaker... and they are already pretty weak.

So doing this in conjunction with a future reconsidering of structure balance and resiliency is the way to go.

@KJeff01 KJeff01 force-pushed the damageFormulaFix branch 5 times, most recently from 2aeb4f5 to 3416668 Compare September 19, 2023 16:59
@KJeff01 KJeff01 force-pushed the damageFormulaFix branch 2 times, most recently from e37e490 to ae73a7c Compare September 29, 2023 01:33
@KJeff01 KJeff01 force-pushed the damageFormulaFix branch 3 times, most recently from 393dcf5 to 6e8bf17 Compare October 15, 2023 16:49
@KJeff01 KJeff01 force-pushed the damageFormulaFix branch 4 times, most recently from 939f6d7 to 8e2c6a2 Compare October 20, 2023 15:40
@KJeff01 KJeff01 force-pushed the damageFormulaFix branch 2 times, most recently from 6736ee7 to d23cc04 Compare October 29, 2023 23:40
@GiantEnemyCrabKing
Copy link

Do you though?

Structures are particularly weak, but if the damage in reality was being modified by 6%, then just changing all structuremodifier.json values by -6% should achieve a similar result, no?

@KJeff01 KJeff01 force-pushed the damageFormulaFix branch 2 times, most recently from fc19692 to 9817f87 Compare November 10, 2023 19:02
@KJeff01 KJeff01 added this to the 4.5.0 milestone Nov 14, 2023
Since level defaulted to 1 it meant structures/features here would set actualDamage to 94% as the base damage value.
@KJeff01 KJeff01 marked this pull request as ready for review December 9, 2023 19:12
@KJeff01 KJeff01 merged commit a19141c into Warzone2100:master Dec 9, 2023
35 checks passed
@KJeff01 KJeff01 deleted the damageFormulaFix branch December 9, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants