Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.3.5: build fails #3397

Closed
kloczek opened this issue Oct 2, 2023 · 6 comments
Closed

4.3.5: build fails #3397

kloczek opened this issue Oct 2, 2023 · 6 comments
Labels
Bug

Comments

@kloczek
Copy link

kloczek commented Oct 2, 2023

Describe the bug
Looks like when is used latest gcc 13.2.1 build fails with:

[ 78%] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/gfx_api_vk.cpp.o
cd /home/tkloczko/rpmbuild/BUILD/warzone2100/x86_64-redhat-linux-gnu/lib/ivis_opengl && /usr/bin/g++ -DBASISU_HAVE_STD_TRIVIALLY_COPYABLE -DBASIS_ENABLED -DETCPAK_ENABLED -DHAVE_CONFIG_H -DJSON_USE_IMPLICIT_CONVERSIONS=0 -DNLOHMANN_JSON_NAMESPACE=nlohmann -DNLOHMANN_JSON_NAMESPACE_BEGIN="namespace nlohmann {" -DNLOHMANN_JSON_NAMESPACE_END=} -DWZ_DEBUG_GFX_API_LEAKS -DWZ_FRIBIDI_ENABLED -DWZ_VULKAN_ENABLED -I/home/tkloczko/rpmbuild/BUILD/warzone2100/x86_64-redhat-linux-gnu -I/home/tkloczko/rpmbuild/BUILD/warzone2100/. -I/home/tkloczko/rpmbuild/BUILD/warzone2100/3rdparty -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/fribidi -I/home/tkloczko/rpmbuild/BUILD/warzone2100/3rdparty/optional-lite/include -I/home/tkloczko/rpmbuild/BUILD/warzone2100/3rdparty/launchinfo/include -I/home/tkloczko/rpmbuild/BUILD/warzone2100/3rdparty/glad/include -I/home/tkloczko/rpmbuild/BUILD/warzone2100/lib/ivis_opengl/3rdparty/etcpak -I/home/tkloczko/rpmbuild/BUILD/warzone2100/3rdparty/basis_universal/transcoder -isystem /home/tkloczko/rpmbuild/BUILD/warzone2100/3rdparty/glm -isystem /home/tkloczko/rpmbuild/BUILD/warzone2100/3rdparty/date/include -isystem /home/tkloczko/rpmbuild/BUILD/warzone2100/3rdparty/json/include -O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none -fstack-protector-strong -fstack-clash-protection -DNDEBUG -std=c++14 -fPIC -Wpedantic -Wall -Wextra -fno-common -fno-math-errno -Wcast-align -Wcast-qual -Wctor-dtor-privacy -Winit-self -Woverloaded-virtual -Wstrict-null-sentinel -Wwrite-strings -Wpointer-arith -Wmissing-noreturn -Wnon-virtual-dtor -Wduplicated-cond -Walloc-zero -Walloca-larger-than=1024 -Wrestrict -Wfloat-conversion -Wformat-security -Wstringop-truncation -Wlogical-op -Wuninitialized -Wno-float-conversion -Wno-unused-but-set-variable -Wno-sign-compare -Wno-unused-parameter -Wno-format-truncation -MD -MT lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/gfx_api_vk.cpp.o -MF CMakeFiles/ivis-opengl.dir/gfx_api_vk.cpp.o.d -o CMakeFiles/ivis-opengl.dir/gfx_api_vk.cpp.o -c /home/tkloczko/rpmbuild/BUILD/warzone2100/lib/ivis_opengl/gfx_api_vk.cpp
/home/tkloczko/rpmbuild/BUILD/warzone2100/lib/ivis_opengl/gfx_api_vk.cpp: In member function ‘void BlockBufferAllocator::allocateNewBlock(uint32_t)’:
/home/tkloczko/rpmbuild/BUILD/warzone2100/lib/ivis_opengl/gfx_api_vk.cpp:524:21: error: ‘throwResultException’ is not a member of ‘vk’; did you mean ‘vk::detail::throwResultException’?
  524 |                 vk::throwResultException( result, "vmaCreateBuffer" );
      |                     ^~~~~~~~~~~~~~~~~~~~
In file included from /home/tkloczko/rpmbuild/BUILD/warzone2100/lib/ivis_opengl/gfx_api_vk.h:39,
                 from /home/tkloczko/rpmbuild/BUILD/warzone2100/lib/ivis_opengl/gfx_api_vk.cpp:42:
/usr/include/vulkan/vulkan.hpp:6782:41: note: ‘vk::detail::throwResultException’ declared here
 6782 |     [[noreturn]] VULKAN_HPP_INLINE void throwResultException( Result result, char const * message )
      |                                         ^~~~~~~~~~~~~~~~~~~~
/home/tkloczko/rpmbuild/BUILD/warzone2100/lib/ivis_opengl/gfx_api_vk.cpp: In constructor ‘VkPSO::VkPSO(vk::Device, const vk::PhysicalDeviceLimits&, const gfxapi_PipelineCreateInfo&, vk::RenderPass, const std::shared_ptr<VkhRenderPassCompat>&, vk::SampleCountFlagBits, const vk::DispatchLoaderDynamic&, const VkRoot&)’:
/home/tkloczko/rpmbuild/BUILD/warzone2100/lib/ivis_opengl/gfx_api_vk.cpp:1543:29: error: ‘throwResultException’ is not a member of ‘vk’; did you mean ‘vk::detail::throwResultException’?
 1543 |                         vk::throwResultException(result.result, "createGraphicsPipeline");
      |                             ^~~~~~~~~~~~~~~~~~~~
/usr/include/vulkan/vulkan.hpp:6782:41: note: ‘vk::detail::throwResultException’ declared here
 6782 |     [[noreturn]] VULKAN_HPP_INLINE void throwResultException( Result result, char const * message )
      |                                         ^~~~~~~~~~~~~~~~~~~~
/home/tkloczko/rpmbuild/BUILD/warzone2100/lib/ivis_opengl/gfx_api_vk.cpp: In member function ‘void VkBuf::allocateBufferObject(const std::size_t&)’:
/home/tkloczko/rpmbuild/BUILD/warzone2100/lib/ivis_opengl/gfx_api_vk.cpp:1607:21: error: ‘throwResultException’ is not a member of ‘vk’; did you mean ‘vk::detail::throwResultException’?
 1607 |                 vk::throwResultException( result, "vmaCreateBuffer" );
      |                     ^~~~~~~~~~~~~~~~~~~~
/usr/include/vulkan/vulkan.hpp:6782:41: note: ‘vk::detail::throwResultException’ declared here
 6782 |     [[noreturn]] VULKAN_HPP_INLINE void throwResultException( Result result, char const * message )
      |                                         ^~~~~~~~~~~~~~~~~~~~
/home/tkloczko/rpmbuild/BUILD/warzone2100/lib/ivis_opengl/gfx_api_vk.cpp: In constructor ‘VkTexture::VkTexture(const VkRoot&, const std::size_t&, const std::size_t&, const std::size_t&, const gfx_api::pixel_format&, const std::string&)’:
/home/tkloczko/rpmbuild/BUILD/warzone2100/lib/ivis_opengl/gfx_api_vk.cpp:1740:21: error: ‘throwResultException’ is not a member of ‘vk’; did you mean ‘vk::detail::throwResultException’?
 1740 |                 vk::throwResultException( result, "vmaCreateImage" );
      |                     ^~~~~~~~~~~~~~~~~~~~
/usr/include/vulkan/vulkan.hpp:6782:41: note: ‘vk::detail::throwResultException’ declared here
 6782 |     [[noreturn]] VULKAN_HPP_INLINE void throwResultException( Result result, char const * message )
      |                                         ^~~~~~~~~~~~~~~~~~~~
make[2]: *** [lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/build.make:177: lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/gfx_api_vk.cpp.o] Error 1
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/warzone2100/x86_64-redhat-linux-gnu'
make[1]: *** [CMakeFiles/Makefile2:1301: lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/all] Error 2
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/warzone2100/x86_64-redhat-linux-gnu'

Your System:

  • OS:: Linux x86/64
  • Game version: 4.3.5

Additional context
cmake setup:

[tkloczko@pers-jacek x86_64-redhat-linux-gnu]$ cmake -L
CMake Warning:
  No source or binary directory provided.  Both will be assumed to be the
  same as the current working directory, but note that this warning will
  become a fatal error in future CMake releases.


CMake Error: The source directory "/home/tkloczko/rpmbuild/BUILD/warzone2100/x86_64-redhat-linux-gnu" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.
-- Cache values
BUILD_EXAMPLES:BOOL=OFF
BUILD_SHARED_LIBS:BOOL=OFF
BUILD_TESTING:BOOL=ON
CMAKE_BUILD_TYPE:STRING=RelWithDebInfo
CMAKE_INSTALL_PREFIX:PATH=/usr
CPACK_COMMAND:FILEPATH=/usr/bin/cpack
CURL_CONFIG_EXECUTABLE:FILEPATH=/usr/bin/curl-config
DISCORDRPC_ENABLE_CLANG_FORMAT:BOOL=OFF
ENABLE_DISCORD:BOOL=ON
ENABLE_DOCS:BOOL=ON
ENABLE_IO_THREAD:BOOL=ON
ENABLE_NLS:BOOL=ON
FMT_CUDA_TEST:BOOL=OFF
FMT_DEBUG_POSTFIX:STRING=d
FMT_DOC:BOOL=OFF
FMT_FUZZ:BOOL=OFF
FMT_INC_DIR:STRING=include
FMT_INSTALL:BOOL=OFF
FMT_MODULE:BOOL=OFF
FMT_OS:BOOL=ON
FMT_PEDANTIC:BOOL=OFF
FMT_SYSTEM_HEADERS:BOOL=OFF
FMT_TEST:BOOL=OFF
FMT_WERROR:BOOL=OFF
GLSLC:FILEPATH=/usr/bin/glslc
GZIP_BIN:FILEPATH=/usr/bin/gzip
JSON_Diagnostics:BOOL=OFF
JSON_ImplicitConversions:BOOL=OFF
JSON_SystemInclude:BOOL=ON
NO_GETADDRINFO:BOOL=OFF
OPUS_MULTISTREAM_DIR:PATH=/usr/include/opus
OpenAL_DIR:PATH=/usr/lib64/cmake/OpenAL
RAPIDJSON:FILEPATH=/home/tkloczko/rpmbuild/BUILD/warzone2100/3rdparty/discord-rpc/thirdparty/rapidjson
RE2_BUILD_TESTING:BOOL=OFF
SDL2_DIR:PATH=/usr/lib64/cmake/SDL2
SQLITECPP_BUILD_EXAMPLES:BOOL=OFF
SQLITECPP_BUILD_TESTS:BOOL=OFF
SQLITECPP_INCLUDE_SCRIPT:BOOL=OFF
SQLITECPP_INTERNAL_SQLITE:BOOL=OFF
SQLITECPP_RUN_CPPCHECK:BOOL=OFF
SQLITECPP_RUN_CPPLINT:BOOL=OFF
SQLITECPP_RUN_DOXYGEN:BOOL=OFF
SQLITECPP_USE_ASAN:BOOL=OFF
SQLITECPP_USE_GCOV:BOOL=OFF
SQLITECPP_USE_STACK_PROTECTION:BOOL=ON
SQLITECPP_USE_STATIC_RUNTIME:BOOL=OFF
SQLITE_ENABLE_ASSERT_HANDLER:BOOL=OFF
SQLITE_ENABLE_COLUMN_METADATA:BOOL=OFF
SQLITE_HAS_CODEC:BOOL=OFF
SQLITE_OMIT_LOAD_EXTENSION:BOOL=OFF
SQLITE_USE_LEGACY_STRUCT:BOOL=OFF
UPNPC_BUILD_SAMPLE:BOOL=OFF
UPNPC_BUILD_SHARED:BOOL=OFF
UPNPC_BUILD_STATIC:BOOL=ON
UPNPC_BUILD_TESTS:BOOL=OFF
UPNPC_NO_INSTALL:BOOL=TRUE
USEPCRE:BOOL=OFF
USE_STATIC_CRT:BOOL=OFF
UTF8PROC_ENABLE_TESTING:BOOL=OFF
UTF8PROC_INSTALL:BOOL=OFF
WARNINGS_AS_ERRORS:BOOL=OFF
WZ_DEBUG_GFX_API_LEAKS:BOOL=ON
WZ_DISTRIBUTOR:STRING=G2V
WZ_ENABLE_BACKEND_VULKAN:BOOL=ON
WZ_ENABLE_BASIS_UNIVERSAL:BOOL=ON
WZ_ENABLE_WARNINGS:BOOL=OFF
WZ_ENABLE_WARNINGS_AS_ERRORS:BOOL=OFF
WZ_FINDSDL2_NOCONFIG:BOOL=OFF
WZ_FORCE_MINIMAL_OPUSFILE:BOOL=ON
libzip_DIR:PATH=libzip_DIR-NOTFOUND
sodium_INCLUDE_DIR:PATH=/usr/include
sodium_LIBRARIES:FILEPATH=/usr/lib64/libsodium.so
@kloczek kloczek added the Bug label Oct 2, 2023
@vaut
Copy link
Contributor

vaut commented Oct 2, 2023

#2479

@kloczek
Copy link
Author

kloczek commented Oct 2, 2023 •
edited
Loading

#2479

That PR is fixing issue which I've reported against 4.2.3.
In this case it is issue with 4.3.5.

@past-due
Copy link
Member

past-due commented Oct 4, 2023

Fixed in #3353

@kloczek
Copy link
Author

kloczek commented Oct 4, 2023

Cannot test PR because it is not possible to apply it on top os last release and since last release have been added +400 commits.

Do you have any plans to make new release .. soon? 😋 🤔

@KJeff01
Copy link
Member

KJeff01 commented Oct 4, 2023

That will depend on how fast our artist can fixup the current models to work well with the shadow mapping PR. And that's just for the first beta release for 4.4.

@kloczek
Copy link
Author

kloczek commented Oct 4, 2023

Maybe it would be good to release 3.4.6 with backported only some most important fixes? 🤔

@KJeff01 KJeff01 closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vaut @KJeff01 @past-due @kloczek