From 520f6699742b56ef8fe477bc85d2f487b119ba7b Mon Sep 17 00:00:00 2001 From: Michael Milton Date: Fri, 6 Sep 2024 10:38:14 +1000 Subject: [PATCH] More changelog detail --- docs/changelog.md | 2 ++ filesender/api.py | 2 -- pyproject.toml | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/changelog.md b/docs/changelog.md index b2bd574..4ef428a 100644 --- a/docs/changelog.md +++ b/docs/changelog.md @@ -8,6 +8,8 @@ ### Changed +* Files are now downloaded into the appropriate subdirectory. For example if you upload `parent/child.txt`, and then later download that file, the `parent` subdirectory will be created. +* `FileSenderClient.download_file` now has some additional args: `file_size` and `file_name` which will enable better functionality if provided. They are typically obtained from `FileSenderClient._files_from_token` * All terminal output is now through the `logging` module. You can use the new `--log-level` CLI parameter to configure the amount of info that is printed out. * Update the CLI default concurrency to 2 for chunks and 1 for files. This seems to be moderately performant without ever failing diff --git a/filesender/api.py b/filesender/api.py index ca0bbb3..3dd160f 100644 --- a/filesender/api.py +++ b/filesender/api.py @@ -343,8 +343,6 @@ async def download_files( """ Downloads all files for a transfer. - Note that currently the directory hierarchy won't be preserved. So if the original user uploaded `dir_a/file_a.txt` and `dir_b/file_b.txt`, they will simply be downloaded as `file_a.txt` and `file_b.txt` with their directories stripped out. This is a limitation of the current API. See https://github.com/filesender/filesender/issues/1555 for context. - Params: token: Obtained from the transfer email. The same as [`GuestAuth`][filesender.GuestAuth]'s `guest_token`. out_dir: The path to write the downloaded files. diff --git a/pyproject.toml b/pyproject.toml index f38d3e0..59711dd 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -48,7 +48,8 @@ dev = [ "pandas", "jupyter", "notebook<7", - "nbconvert" + "nbconvert", + "jupyter_contrib_nbextensions" ] [project.scripts]