Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certain complicated commit histories are highlighted incorrectly #766

Open
chiphogg opened this issue Nov 6, 2016 · 1 comment · Fixed by 5HT2C/Vundle.vim#2 · May be fixed by #767
Open

Certain complicated commit histories are highlighted incorrectly #766

chiphogg opened this issue Nov 6, 2016 · 1 comment · Fixed by 5HT2C/Vundle.vim#2 · May be fixed by #767
Milestone
0.10.3

Comments

@chiphogg
Copy link
Contributor

chiphogg commented Nov 6, 2016

This is for the "updates" view. Here is an example:

  *   Merge pull request #1148 from chrisbra/1131   Christian Brabandt, 6 months ago
  |\
  | * Make sure the statusline option is correct   Christian Brabandt, 6 months ago
  * |   Merge pull request #1152 from chrisbra/1146   Christian Brabandt, 6 months ago
  |\ \
  | * | Check that default value exists, before accessing it   Christian Brabandt, 6 months ago
  * | |   Merge pull request #1147 from hanxueluo/master   Christian Brabandt, 6 months ago
  |\ \ \
  | |_|/
  |/| |
  | * | shellescape file path when call "system()"   hanhuanle, 6 months ago
  | |/
  * |   Merge pull request #1145 from chrisbra/1144   Christian Brabandt, 6 months ago

The line with the _ is not recognized as depicting a commit tree, so it does not get highlighted.

I believe the fix should be simple; if so, I'll put out a pull request soon.
chiphogg added a commit to chiphogg/Vundle.vim that referenced this issue Nov 6, 2016
@chiphogg
Recognize underscores as commit tree characters
1acc452 
Currently, any line in a commit tree representation with an underscore
will not be highlighted correctly.  The solution is to add the
underscore to the list of commit tree characters.

Fixes VundleVim#766.
@chiphogg chiphogg linked a pull request Nov 6, 2016 that will close this issue
Open
@ryanoasis
Copy link
Member

related though not exactly is #791

@ryanoasis ryanoasis added this to the 0.10.3 milestone Apr 8, 2017
@5HT2 5HT2 mentioned this issue Sep 3, 2024
Merged
5HT2 pushed a commit to 5HT2C/Vundle.vim that referenced this issue Sep 3, 2024
@chiphogg @5HT2
Recognize underscores as commit tree characters
d805739 
Currently, any line in a commit tree representation with an underscore
will not be highlighted correctly.  The solution is to add the
underscore to the list of commit tree characters.

Fixes VundleVim#766.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.3
2 participants
@chiphogg @ryanoasis